[FIX] mass_mailing: scroll in iframe mass_mailing form #164666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Seems legit to me, I would mention 8a74c1f in the commit message as it's not really clear how it's supposed to work without the original context. |
|
"You can scroll inside the template" you mean can't, right? |
Mtaylorr
force-pushed
the
16.0-opw-3897165-macr
branch
from
f011028
to
09e6c5c
Compare
Issue: ===== We can't scroll in iframe using the mouse (no scroll available) Steps to reproduce the issue: ============================= - Install events, mass_mailing - Go to any event and click invite - Choose any template - You can't scroll inside the template Origin of the issue: ==================== Many other apps inherits the view with id `view_mail_mass_mailing_form` and not the view with id `mailing_mailing_view_form_full_width` which have the logic of resizing the iframe to the length of its content (introduced here [1]) so we don't really need to scroll inside the iframe. But for the other apps since they inherit from the first mentioned view, they will have the iframe class `.o_mass_mailing_iframe` but we specified in mass_mailing.ui.scss file that html that have that class we don't assign `overflow:visible` to them , that's why we can't scroll inside the iframe. Solution: ========= There are a lof of ways to solve this problem but most of them needs an xml change which requires an update of the module. The current solution is to add a special class to the full_width view using js from it's already defined js_class and then we exclude it from the scss selector. opw-3897165 [1]: odoo@8a74c1f
Mtaylorr
force-pushed
the
16.0-opw-3897165-macr
branch
from
09e6c5c
to
d29a4e1
Compare
|
@reth-odoo , @dmo-odoo , I updated the commit message and fixed the typos, let me know what you think , thanks ! |
|
The iframe itself is not aware of whether its parent component is in full width or not. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
Issue: ===== We can't scroll in iframe using the mouse (no scroll available) Steps to reproduce the issue: ============================= - Install events, mass_mailing - Go to any event and click invite - Choose any template - You can't scroll inside the template Origin of the issue: ==================== Many other apps inherits the view with id `view_mail_mass_mailing_form` and not the view with id `mailing_mailing_view_form_full_width` which have the logic of resizing the iframe to the length of its content (introduced here [1]) so we don't really need to scroll inside the iframe. But for the other apps since they inherit from the first mentioned view, they will have the iframe class `.o_mass_mailing_iframe` but we specified in mass_mailing.ui.scss file that html that have that class we don't assign `overflow:visible` to them , that's why we can't scroll inside the iframe. Solution: ========= There are a lof of ways to solve this problem but most of them needs an xml change which requires an update of the module. The current solution is to add a special class to the full_width view using js from it's already defined js_class and then we exclude it from the scss selector. opw-3897165 [1]: 8a74c1f closes #164666 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We can't scroll in iframe using the mouse (no scroll available)
Steps to reproduce the issue:
Origin of the issue:
Many other apps inherits the view with id
view_mail_mass_mailing_formand not the view with id
mailing_mailing_view_form_full_widthwhichhave the logic of resizing the iframe to the length of its content
(introduced here 1) so we don't really need to scroll inside the
iframe. But for the other apps since they inherit from the first
mentioned view, they will have the iframe class
.o_mass_mailing_iframebut we specified in mass_mailing.ui.scss file that html that have that
class we don't assign
overflow:visibleto them , that's why we can'tscroll inside the iframe.
Solution:
There are a lof of ways to solve this problem but most of them needs an
xml change which requires an update of the module. The current solution
is to add a special class to the full_width view using js from it's
already defined js_class and then we exclude it from the scss selector.
opw-3897165