[FIX]account/saas-16.2: Chart Template es_common

[syna-odoo]

Description of the issue/feature this PR addresses:

Current behavior before PR:

Steps To Reproduce:

1. Create fresh database in version 16.0.
2. Install the module l10n_es.
3. Migrate the database to version 17.0 or saas-16.2 by setting the chart_template_id of res_company to es_common which is
   id = 1.
4. Finally, the error will be reproduced.

When the module l10n_es is installed and if the Chart Template is set to es_common before saas-16.2 then it will raise a TypeError as "TypeError: 'NoneType' object is not subscriptable" when migrating to version 17.0 or saas-16.2. It is just because the changes in this PR here the chart template has made invisible ('visible':0). So, when it tries to fetch the template with the template_code es_common it will get a None value because it has made invisible. Finally, it will surely raise a TypeError if the chart template is set to es_common.

Desired behavior after PR is merged:

The TypeError which is raising while migrating to version saas-16.2 or more will be handled with this PR just by setting the value True for the default parameter get_all of the method _get_chart_template_mapping() .

Proof: Link

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

This PR targets the disabled branch odoo/odoo:saas-16.2, it needs to be retargeted before it can be merged.

[robodoo]

.

[dbkosky]

@syna-odoo
I've been trying to replicate the error using the described steps but have had no success.
Could you be more specific?

"""
Migrate the database to version 17.0 or saas-16.2 by setting the chart_template_id of res_company to es_common which is
id = 1.
"""
It's unclear what you mean here. In testing, I've checkout out on version saas-16.2 and run -u all.

When it comes to setting the chart template to es_common (PGCE común), it cannot be selected from the list of available chart templates in v16.0 (see screenshot)

Are you suggesting that it should be set in some other way (e.g. using the shell)?
Is there some case in the past where some users were able to set their chart template to PGCE común from the interface?

[syna-odoo]

Hello @dbkosky
Hope you are good...!

Yeah, I saw that the customer's db has that particular template 'es_common' set for his company and it is carried over from version 8.0 but I saw that template is inactive in our standard from verison 11.0.
So, I just set that template through shell while testing and not checking the UI side. And it is my bad.
We just have to make changes in the customers db as it(es_common) is not active in our standard.

So, shall we close this PR?
Thanks for your review.
Have a nice day ahead!!!

[dbkosky]

@syna-odoo
In that case I think it would be best to close the PR then.
Thanks for explaining how it happened as well
Have a good day 🙂

[syna-odoo]

Made changes in the customers database as the templatees_commom is not available in our standard.
So, closing this PR :)