[FW][FIX] web_editor, mass_mailing: shapes don't save

[fw-bot]

Current behavior:

When logged as a mass mailing user, in a mailing, using the editor,
when applying a shape to an image, the image disappears.

Steps to reproduce:

1. Make sure Marc Demo has the role User
2. Log in as Marc Demo
3. Create a new mailing
4. Select a template
5. Insert a picture
6. Select the picture
7. Change its shape to round
8. (preview works fine)
9. Save the mailing
10. Picture disappears

Cause of the issue:

When applying a shape to an image, the resulting file is of mimetype 'image/svg+xml',
when sending it to the server, the attachment is going to go through _check_contents

odoo/odoo/addons/base/models/ir_attachment.py

Line 364 in d752abb

not self.env['ir.ui.view'].with_user(user).check_access_rights('write', False))

and if the mimetype is "xml_like", it will check for views write rights,
without what the mimetype will be forced to text/plain.

But in web_editor, when computing the image src

odoo/addons/web_editor/models/ir_attachment.py

Line 34 in b6392e2

attachment.image_src = False

if the mimetype is not a supported image type, src will be False.

Fix:

Override of _writeShape to use canvas to convert the image from svg to png.

opw-3672798

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #164013
Forward-Port-Of: #159497

[robodoo]

.

[fw-bot]

@ande-odoo cherrypicking of pull request #159497 failed.

stdout:

Auto-merging addons/mass_mailing/static/src/js/mass_mailing_snippets.js
CONFLICT (content): Merge conflict in addons/mass_mailing/static/src/js/mass_mailing_snippets.js
Auto-merging addons/web_editor/static/src/js/editor/snippets.options.js
CONFLICT (content): Merge conflict in addons/web_editor/static/src/js/editor/snippets.options.js

stderr:

12:53:42.895837 git.c:463               trace: built-in: git cherry-pick b270e23dd90bf8e81a2b77f8025dfe9d57341caa
error: could not apply b270e23dd90b... [FIX] web_editor, mass_mailing: shapes don't save
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[ande-odoo]

Hi @reth-odoo @Goaman I had to adapt my fix and the code around in this forward port, could you give me a review ? Thanks

[reth-odoo]

Seems probably ok but I'll leave editor review to team editor. Just leaving a comment as runbot is red 👀

[ande-odoo]

Hi @odoo/rd-framework-editor Could you review my fw port, as I had to adapt my fix for this version ? Thanks !

[dmo-odoo]

@ande-odoo I assume it would make more sense for @bvr-odoo to have a look now since the additional changes you made seem to be the lines added in #134979.

[bvr-odoo]

@ande-odoo I assume it would make more sense for @bvr-odoo to have a look now since the additional changes you made seem to be the lines added in #134979.

@ande-odoo Hello, I tested the branch and hover effect are no longer works with your changes.
Try not to change the order in which things happen when a shape is applied. This will help keep things from breaking ;)
Thanks 👍

[ande-odoo]

Hi @bvr-odoo It seems like everything is working now, can you have a look ? Thanks !

[bvr-odoo]

Hi @bvr-odoo It seems like everything is working now, can you have a look ? Thanks !

@ande-odoo LGTM 👍 , I tested it in Website and everything works, thanks

[ande-odoo]

@robodoo r+