Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pos_sale: cancel all transfers after settling order #164753

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] pos_sale: cancel all transfers after settling order #164753

wants to merge 1 commit into from
+3 −1

Conversation

AH-Yussef
Copy link
Contributor

Steps to reproduce:

  • Install POS app
  • Change the warehouse to a 2-step delivery method
  • Create a sales order for a product and confirm
  • Ensure the product is reserved for the picking transfer as the issue doesn't exist (all transfers are successfully cancelled) if there are no products reserved
  • Go to POS and settle the sales order
  • The delivery transfer is cancelled but the picking transfer (with product reserved) is not cancelled. although all transfers should be cancelled if the order is fully delivered!

Investigation:

  • When the product is already reserved, the picking transfer is in the Ready/assigned state
  • When updating the steps, the Ready/assigned state is not taken into consideration and so the picking transfer is not updated to be cancelled

opw-3474929

@AH-Yussef AH-Yussef self-assigned this May 7, 2024
@robodoo
Copy link
Contributor

robodoo commented May 7, 2024

Pull request status dashboard.

@AH-Yussef
[FIX] pos_sale: cancel all transfers after settling order
dcf95dc 
- Install POS app
- Change the warehouse to a 2-step delivery method
- Create a sales order for a product and confirm
- Ensure the product is reserved for the picking transfer **as** the issue doesn't exist (all transfers are successfully cancelled) if there are no products reserved
- Go to POS and settle the sales order
- The delivery transfer is cancelled but the picking transfer (with product reserved) is not cancelled. although all transfers should be cancelled if the order is fully delivered!

- When the product is already reserved, the picking transfer is in the **Ready/assigned** state
- When updating the steps, the **Ready/assigned** state is not taken into consideration and so the picking transfer is not updated to be **cancelled**

opw-3474929
@AH-Yussef AH-Yussef force-pushed the 16.0-opw-3474929-cancel_all_transfers_after_settling_order_in_pos-alhy branch from 0c7890f to dcf95dc Compare May 7, 2024 13:56
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 7, 2024
nle-odoo
nle-odoo approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nle-odoo nle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@AH-Yussef AH-Yussef marked this pull request as ready for review May 15, 2024 12:07
@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team May 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nle-odoo nle-odoo nle-odoo approved these changes

@caburj caburj Awaiting requested review from caburj caburj was automatically assigned from odoo/pos

Assignees

@AH-Yussef AH-Yussef

Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AH-Yussef @robodoo @nle-odoo @C3POdoo