[IMP] pos_coupon: Speed-up computing domain for products and partners #164771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@caburj What do you think? |
adgu-odoo
requested changes
May 8, 2024
moylop260
force-pushed
the
15.0-speedup-coupon-odoo-moy
branch
from
f94d0f7
to
4b73999
Compare
moylop260
changed the title
moylop260
force-pushed
the
15.0-speedup-coupon-odoo-moy
branch
from
4b73999
to
5e5e638
Compare
|
LGTM 👍 |
|
@adgu-odoo Could you review it, please? |
|
You can revert what I said about literal_eval and then ping me when the runbot is green |
- Re-using result for domains duplicated - Ordering by id instead of default heavy unused order
moylop260
force-pushed
the
15.0-speedup-coupon-odoo-moy
branch
from
5e5e638
to
bfb97ef
Compare
|
Thank you for reply! I have created the changes requested and the runbot CI is green now |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 23, 2024
- Re-using result for domains duplicated - Ordering by id instead of default heavy unused order closes #164771 Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
|
@moylop260 @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@moylop260 @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@moylop260 @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
I have created the following FW PR manually: |
|
@moylop260 @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced May 30, 2024
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 3, 2024
- Re-using result for domains duplicated - Ordering by id instead of default heavy unused order closes odoo#164771 Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a POS sessions our SQL profiler shows the following query executed too many times:
Checking the PY profilers the following method is reported as slow:
odoo/addons/pos_coupon/models/coupon_program.py
Line 80 in 42f5e84
The reason it is executing the same query too many times with the same domain
So, I have created this change to re-use the result if the domain is repeated
Also, the query generated has heavy
order byorder by "res_partner"."type", coalesce("res_partner"."is_company", false) desc, "res_partner"."display_name", "res_partner"."id";Replacing by
order by "res_partner"."id"it is fasterBefore
Execution Time: 104.256 msNow
Execution Time: 31.802 msSo, it is ~4x faster for each query and it is re-using data for the same query using a LRU-Cache locally in the method