[FIX] account: Fixed inconsistent tax grids on journal entries #164801
Conversation
This commit ensure that tax_tag_ids are cleared when tax_ids are cleared on the account_move_line. Before this commit, when a new journal entry is created, adding a tax with tax grids then removing the tax does not remove the grids. task-3906808
|
|
|
@william-andre There might be a better solution to the problem, but I spent some time trying to figure out another solution but could not find any. The problem I could identify was that the |
| @@ -1185,6 +1185,12 @@ def action_register_payment(self): | |||
| # INVERSE METHODS | |||
| # ------------------------------------------------------------------------- | |||
|
|
|||
| @api.onchange('tax_ids') | |||
There was a problem hiding this comment.
This only works in the UI but won't work if the tax is removed programmatically
There was a problem hiding this comment.
and what is a better solution in that case?
There was a problem hiding this comment.
should I override the write method?
There was a problem hiding this comment.
The issue is probably something in _sync_dynamic_lines that doesn't work
There was a problem hiding this comment.
To get started, let's start by writing a test 😉 (not using the Form emulator)
This commit ensure that tax_tag_ids are cleared when tax_ids are cleared on the account_move_line.
Before this commit, when a new journal entry is created, adding a tax with tax grids then removing the tax does not remove the grids.
task-3906808
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr