Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] stock, mrp: Transfer,MO cancel warning #164911

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 8, 2024

Description of the issue/feature this PR addresses:
This PR aims to address the issue where the cancel buttons (on transfer and MO) are prone to accidental presses due to their proximity. Currently, pressing the cancel button immediately cancels the transfer or MO.

Current behavior before PR:
Pressing the cancel button results in immediate cancellation of the transfer or MO.

Desired behavior after PR is merged:
After merging this PR, Odoo will prompt for confirmation when the cancel button on a transfer or MO is pressed. This will help prevent accidental cancellations. Additionally, the confirmation warning should always be present for both cancel buttons on the MO to ensure consistency.
See below attached for a confirmation message:
On transfer,
picking_cancel_warning

On MO,
mo_cancel_warning


I confirm I have signed the CLA and read the PR guidelines at submit-pr

Forward-Port-Of: #160609

It's too easy to cancel a picking or a manufacturing by mistake.
In the opposite it's hard to reverse the error since there is no
reset to draft or any easy way to remove the cancel state.

The best solution would be to have an easy way to fix the issue but
until a proper solution a simple warning message could be useful

X-original-commit: b4a395a
@robodoo
Copy link
Contributor

robodoo commented May 8, 2024

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented May 8, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 8, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label May 8, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented May 8, 2024

@fd-oerp @amoyaux the next pull request (#164934) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@ticodoo
Copy link
Contributor

ticodoo commented May 29, 2024

@fw-bot r+

robodoo pushed a commit that referenced this pull request May 29, 2024
It's too easy to cancel a picking or a manufacturing by mistake.
In the opposite it's hard to reverse the error since there is no
reset to draft or any easy way to remove the cancel state.

The best solution would be to have an easy way to fix the issue but
until a proper solution a simple warning message could be useful

closes #164911

X-original-commit: b4a395a
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
robodoo pushed a commit that referenced this pull request May 29, 2024
It's too easy to cancel a picking or a manufacturing by mistake.
In the opposite it's hard to reverse the error since there is no
reset to draft or any easy way to remove the cancel state.

The best solution would be to have an easy way to fix the issue but
until a proper solution a simple warning message could be useful

closes #164911

X-original-commit: b4a395a
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
@robodoo robodoo closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants