-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] pos_restaurant: allow orders w\o table #164918
Open
vlst-odoo
wants to merge
2
commits into
odoo:master
Choose a base branch
from
odoo-dev:master-pos_restaurant_table_free_orders-vlst
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[IMP] pos_restaurant: allow orders w\o table #164918
vlst-odoo
wants to merge
2
commits into
odoo:master
from
odoo-dev:master-pos_restaurant_table_free_orders-vlst
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
5 times, most recently
from
May 14, 2024 09:23
bfef43d
to
766bd87
Compare
C3POdoo
requested review from
a team,
davidmonnom,
aab-odoo and
BastienFafchamps
and removed request for
a team
May 14, 2024 09:26
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
5 times, most recently
from
May 16, 2024 14:39
28c63a0
to
7b67bbc
Compare
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
4 times, most recently
from
May 22, 2024 08:44
c573c3c
to
0bd50b5
Compare
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
17 times, most recently
from
May 24, 2024 08:58
f6d4337
to
93af0cb
Compare
Can we consider this way ? |
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
3 times, most recently
from
May 28, 2024 11:01
b01b6ac
to
05b4d11
Compare
Traditionally, pos restaurant expects all orders to be associated with a table. This is not always convenient for the end user as many usecases exist where "floating" orders would be prefferable. ex.: orders for delivery, takeout, etc. In this commit we add the ability to create "floating" orders. Because the linking of orders with tables is such an integral part of `pos_restaurant`, we create by default a "shadow" table in each restaurant floor and associate "floating" orders with this table. This allows us to not modify the whole codebase. Aditionally, we create a new ui element that is helpfull when displaying a list of items that might be larger that it's parent element, but where we don't want scrolling. Only as many items as will fit will be displayed, the rest being shown to the user upon clicking on a "show more" button. Another possible usecase for this element could be the category list in pos. Task: 3908568
vlst-odoo
force-pushed
the
master-pos_restaurant_table_free_orders-vlst
branch
from
May 28, 2024 14:41
05b4d11
to
05b2f66
Compare
robodoo rebase-ff r+ |
Merge method set to rebase and fast-forward. |
@vlst-odoo @caburj linked pull request(s) odoo/enterprise#62608 not ready. Linked PRs are not staged until all of them are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditionally, pos restaurant expects all orders to be associated with a
table. This is not always convenient for the end user as many usecases
exist where "floating" orders would be prefferable. ex.: orders for
delivery, takeout, etc.
In this commit we add the ability to create "floating" orders.
Because the linking of orders with tables is such an integral part of
pos_restaurant
, we create by default a "shadow" table in eachrestaurant floor and associate "floating" orders with this table.
This allows us to not modify the whole codebase.
Aditionally, we create a new ui element that is helpfull when displaying
a list of items that might be larger that it's parent element, but where
we don't want scrolling. Only as many items as will fit will be
displayed, the rest being shown to the user upon clicking on a "show
more" button. Another possible usecase for this element could be the
category list in pos.
Task: 3908568
https://github.com/odoo/enterprise/pull/62608
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr