Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] pos_restaurant: allow orders w\o table #164918

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vlst-odoo
Copy link
Contributor

@vlst-odoo vlst-odoo commented May 8, 2024

Traditionally, pos restaurant expects all orders to be associated with a
table. This is not always convenient for the end user as many usecases
exist where "floating" orders would be prefferable. ex.: orders for
delivery, takeout, etc.

In this commit we add the ability to create "floating" orders.

Because the linking of orders with tables is such an integral part of
pos_restaurant, we create by default a "shadow" table in each
restaurant floor and associate "floating" orders with this table.
This allows us to not modify the whole codebase.

Aditionally, we create a new ui element that is helpfull when displaying
a list of items that might be larger that it's parent element, but where
we don't want scrolling. Only as many items as will fit will be
displayed, the rest being shown to the user upon clicking on a "show
more" button. Another possible usecase for this element could be the
category list in pos.

Task: 3908568

https://github.com/odoo/enterprise/pull/62608


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented May 8, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label May 8, 2024
@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch 5 times, most recently from bfef43d to 766bd87 Compare May 14, 2024 09:23
@vlst-odoo vlst-odoo marked this pull request as ready for review May 14, 2024 09:23
@C3POdoo C3POdoo requested review from a team, davidmonnom, aab-odoo and BastienFafchamps and removed request for a team May 14, 2024 09:26
@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch 5 times, most recently from 28c63a0 to 7b67bbc Compare May 16, 2024 14:39
@vlst-odoo vlst-odoo closed this May 16, 2024
@vlst-odoo vlst-odoo deleted the master-pos_restaurant_table_free_orders-vlst branch May 16, 2024 15:10
@vlst-odoo vlst-odoo restored the master-pos_restaurant_table_free_orders-vlst branch May 21, 2024 14:28
@vlst-odoo vlst-odoo reopened this May 21, 2024
@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch 4 times, most recently from c573c3c to 0bd50b5 Compare May 22, 2024 08:44
@vlst-odoo vlst-odoo closed this May 22, 2024
@vlst-odoo vlst-odoo deleted the master-pos_restaurant_table_free_orders-vlst branch May 22, 2024 08:51
@vlst-odoo vlst-odoo restored the master-pos_restaurant_table_free_orders-vlst branch May 22, 2024 09:06
@vlst-odoo vlst-odoo reopened this May 22, 2024
@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch 17 times, most recently from f6d4337 to 93af0cb Compare May 24, 2024 08:58
@davidmonnom
Copy link
Contributor

Can we consider this way ?

#166701

@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch 3 times, most recently from b01b6ac to 05b4d11 Compare May 28, 2024 11:01
Traditionally, pos restaurant expects all orders to be associated with a
table. This is not always convenient for the end user as many usecases
exist where "floating" orders would be prefferable. ex.: orders for
delivery, takeout, etc.

In this commit we add the ability to create "floating" orders.

Because the linking of orders with tables is such an integral part of
`pos_restaurant`, we create by default a "shadow" table in each
restaurant floor and associate "floating" orders with this table.
This allows us to not modify the whole codebase.

Aditionally, we create a new ui element that is helpfull when displaying
a list of items that might be larger that it's parent element, but where
we don't want scrolling. Only as many items as will fit will be
displayed, the rest being shown to the user upon clicking on a "show
more" button. Another possible usecase for this element could be the
category list in pos.

Task: 3908568
@vlst-odoo vlst-odoo force-pushed the master-pos_restaurant_table_free_orders-vlst branch from 05b4d11 to 05b2f66 Compare May 28, 2024 14:41
@caburj
Copy link
Contributor

caburj commented May 29, 2024

robodoo rebase-ff r+

@robodoo
Copy link
Contributor

robodoo commented May 29, 2024

Merge method set to rebase and fast-forward.

@robodoo
Copy link
Contributor

robodoo commented May 29, 2024

@vlst-odoo @caburj linked pull request(s) odoo/enterprise#62608 not ready. Linked PRs are not staged until all of them are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants