[FIX] expression: prevent an error when using a customized field in domain #164924
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain Currently, The issue is occurring because of customized field use in the domain. Steps to reproduce: - Go to Settings > Technical > Database Structure > Fields. - And create a new field with Field Label: New Related Field, Model: Attachment, Field Type: Binary. - Go to Settings > Technical > User Interface > User Defined Filters. - Create a new filter with Model: Attachment, in the domain, select 'New Related Field' that you have created with '=' operator, and right side of the domain as 'win'. - Then save it, the error will occur in the backend. Error Message: Binary field 'Image 1024' stored in attachment: ignore image_1024 != '""' This error message occurs during the use of customized fields in the Domain condition, And this error message is not important. So replace a logger error message with a logger warning message at [1] to prevent this issue. link [1]: https://github.com/odoo/odoo/blob/85ec121fa1838d6fca3caf3e4c82ec267615dd11/odoo/osv/expression.py#L915-L916 sentry-4551348536
|
|
|
Hello @odoo/sentry_reviewers Please review this PR. Thank You 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, The issue is occurring because of customized field use in the domain.
Steps to reproduce:
'New Related Field' that you have created with '=' operator, and right side of the domain as 'win'.
Error Message: Binary field 'Image 1024' stored in attachment: ignore image_1024 != '""'
This error message occurs during the use of customized fields in the Domain condition, And this error message is
not important. So replace a logger error message with a logger warning message at [1] to prevent more error log in terminal.
link [1]:
odoo/odoo/osv/expression.py
Lines 915 to 916 in 85ec121
sentry-4551348536