[IMP] hr_attendance: Add overtime reporting #165084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugj-odoo
force-pushed
the
master-hr-attendance-overtime-reporting-jugj
branch
from
69298da
to
bc17efd
Compare
| </record> | ||
|
|
||
| <menuitem id="menu_hr_attendance_overtime_reporting" name="Extra Hours" parent="menu_hr_attendance_reporting" sequence="15" groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_overtime_action"/> |
There was a problem hiding this comment.
It's my personal opinion, but I think it's better to put menuitems together.. so move this to addons/hr_attendance/views/hr_attendance_view.xml
There was a problem hiding this comment.
hmmm, if there was a menuitems.xml file why not, but here i prefer to have it right next to the action 🤷♂️
mepe-odoo
approved these changes
May 16, 2024
task-3894091
jugj-odoo
force-pushed
the
master-hr-attendance-overtime-reporting-jugj
branch
from
bc17efd
to
96a1553
Compare
Bertrand2
approved these changes
May 23, 2024
Comment on lines
+292
to
+294
| <menuitem id="menu_hr_attendance_reporting" name="Reporting" parent="menu_hr_attendance_root" sequence="15" groups="hr_attendance.group_hr_attendance_officer"/> | ||
|
|
||
| <menuitem id="menu_hr_attendance_attendance_reporting" name="Worked Hours" parent="menu_hr_attendance_reporting" sequence="15" groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_reporting"/> |
There was a problem hiding this comment.
Line length 😇
Suggested change
| <menuitem id="menu_hr_attendance_reporting" name="Reporting" parent="menu_hr_attendance_root" sequence="15" groups="hr_attendance.group_hr_attendance_officer"/> | |
| <menuitem id="menu_hr_attendance_attendance_reporting" name="Worked Hours" parent="menu_hr_attendance_reporting" sequence="15" groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_reporting"/> | |
| <menuitem id="menu_hr_attendance_reporting" name="Reporting" | |
| parent="menu_hr_attendance_root" sequence="15" | |
| groups="hr_attendance.group_hr_attendance_officer"/> | |
| <menuitem id="menu_hr_attendance_attendance_reporting" name="Worked Hours" | |
| parent="menu_hr_attendance_reporting" sequence="15" | |
| groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_reporting"/> |
| </record> | ||
|
|
||
| <menuitem id="menu_hr_attendance_overtime_reporting" name="Extra Hours" parent="menu_hr_attendance_reporting" sequence="15" groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_overtime_action"/> |
There was a problem hiding this comment.
same here
Suggested change
| <menuitem id="menu_hr_attendance_overtime_reporting" name="Extra Hours" parent="menu_hr_attendance_reporting" sequence="15" groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_overtime_action"/> | |
| <menuitem id="menu_hr_attendance_overtime_reporting" name="Extra Hours" | |
| parent="menu_hr_attendance_reporting" sequence="15" | |
| groups="hr_attendance.group_hr_attendance_officer" action="hr_attendance_overtime_action"/> |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 23, 2024
task-3894091 closes #165084 Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
task-3894091 closes odoo#165084 Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-3894091