[FW][FIX] account/saas~16.3: avoid update of unchanged code prefix #165154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the code field of accounts can trigger a lot of recomputes. Especially during upgrades, this can lead to MemoryError. For this reason, in odoo#125320, it was decided that only tags should be updated on account.account when updating a CoA. But, it can happen that a superfluous code update sneeks in through `ResCompany.reflect_code_prefix_change()`, even though the old code and the new one are the same. Avoid this unnecessary update by returning early from the function when old and new code are the same. X-original-commit: 6778137
|
@cawo-odoo @william-andre this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
May 10, 2024
Updating the code field of accounts can trigger a lot of recomputes. Especially during upgrades, this can lead to MemoryError. For this reason, in #125320, it was decided that only tags should be updated on account.account when updating a CoA. But, it can happen that a superfluous code update sneeks in through `ResCompany.reflect_code_prefix_change()`, even though the old code and the new one are the same. Avoid this unnecessary update by returning early from the function when old and new code are the same. closes #165154 X-original-commit: 6778137 Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Carsten Wolff (cawo) <cawo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the code field of accounts can trigger a lot of recomputes. Especially during upgrades, this can lead to MemoryError. For this reason, in #125320, it was decided that only tags should be updated on
account.accountwhen updating a CoA. But, it can happen that a superfluous code update sneeks in throughResCompany.reflect_code_prefix_change(), even though the old code and the new one are the same. Avoid this unnecessary update by returning early from the function when old and new codes are the same.Forward-Port-Of: #165070