Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] sale_project: e-commerce delivered_milestones #165171

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 12, 2024

Steps to reproduce:

Create a Service Product with the Invoicing Policy "Based on Milestones" and publish its eCommerce page.
When logged out, click on "Add to Cart" on the product's eCommerce page. an error message occurs

Bug:
since this commit1 "delivered_milestones" is only a valid selection for users with the group "group_project_milestone"

Fix:
compute the field as sudo to avoid access error but still only allow the correct group to manually set that value

opw-3892462

Forward-Port-Of: #165133
Forward-Port-Of: #164714

Steps to reproduce:

Create a Service Product with the Invoicing Policy "Based on Milestones"
publish its eCommerce page.
When logged out, click on "Add to Cart" on the product's eCommerce page.
an error message occurs

Bug:
since this commit[1] "delivered_milestones" is only a valid selection
for users with the group "group_project_milestone"

Fix:
compute the field as sudo to avoid acces error but still only allow
the correct group to manually set that value

opw-3892462

[1]:odoo@50ffc33

X-original-commit: 3af97a3
@robodoo
Copy link
Contributor

robodoo commented May 12, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented May 12, 2024

This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 12, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 12, 2024
robodoo pushed a commit that referenced this pull request May 12, 2024
Steps to reproduce:

Create a Service Product with the Invoicing Policy "Based on Milestones"
publish its eCommerce page.
When logged out, click on "Add to Cart" on the product's eCommerce page.
an error message occurs

Bug:
since this commit[1] "delivered_milestones" is only a valid selection
for users with the group "group_project_milestone"

Fix:
compute the field as sudo to avoid acces error but still only allow
the correct group to manually set that value

opw-3892462

[1]:50ffc33

closes #165171

X-original-commit: 3af97a3
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
@robodoo robodoo closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants