New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] web_editor: convert inline before send message #165205
[FW][FIX] web_editor: convert inline before send message #165205
Conversation
@Mtaylorr @dmo-odoo cherrypicking of pull request #163323 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
25ed880
to
4f076cb
Compare
Commit that introduced the issue: [1] Issue: ====== The email sent from chatter message isn't correctly formatted. Steps to reproduce the issue: ============================= - Go to chatter of any form view - Open the mail compose modal - Add a primary link the in the email body - Send it - The email isn't formatted in the received email. Origin of the issue: ==================== The flow goes as follow, we first change the field and then when clicking send, we first update the value of the editor by `onWysiwygBlur` , then before the send is done, the field is saved which will trigger the event `NEED_LOCAL_CHANGES` which will call commitChanges, but since we already updated the value and we don't have urgent, nothing will happend and the function `toInline` will never be called. Solution: ========= To not break the old commit behavior and make it reset with disard, we add another flag `shouldInline` so we can force `commitChanges` and calculating inline style when saving. [1]: odoo@3573167 opw-3885368 X-original-commit: b7ecc3f
@robodoo r+ |
Commit that introduced the issue: [1] Issue: ====== The email sent from chatter message isn't correctly formatted. Steps to reproduce the issue: ============================= - Go to chatter of any form view - Open the mail compose modal - Add a primary link the in the email body - Send it - The email isn't formatted in the received email. Origin of the issue: ==================== The flow goes as follow, we first change the field and then when clicking send, we first update the value of the editor by `onWysiwygBlur` , then before the send is done, the field is saved which will trigger the event `NEED_LOCAL_CHANGES` which will call commitChanges, but since we already updated the value and we don't have urgent, nothing will happend and the function `toInline` will never be called. Solution: ========= To not break the old commit behavior and make it reset with disard, we add another flag `shouldInline` so we can force `commitChanges` and calculating inline style when saving. [1]: 3573167 opw-3885368 closes #165205 X-original-commit: b7ecc3f Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
Commit that introduced the issue: 1
Issue:
The email sent from chatter message isn't correctly formatted.
Steps to reproduce the issue:
Origin of the issue:
The flow goes as follow, we first change the field and then when
clicking send, we first update the value of the editor by
onWysiwygBlur
, then before the send is done, the field is saved whichwill trigger the event
NEED_LOCAL_CHANGES
which will callcommitChanges, but since we already updated the value and we don't have
urgent, nothing will happend and the function
toInline
will never becalled.
Solution:
To not break the old commit behavior and make it reset with disard, we
add another flag
shouldInline
so we can forcecommitChanges
andcalculating inline style when saving.
opw-3885368
Forward-Port-Of: #163323