[FW][FIX] web_editor: export icon to png correctly #165273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Mtaylorr
force-pushed
the
saas-17.2-15.0-opw-3865845-macr-gL-Z-fw
branch
from
2d81b38
to
04480e9
Compare
Mtaylorr
force-pushed
the
saas-17.2-15.0-opw-3865845-macr-gL-Z-fw
branch
from
04480e9
to
122fc0c
Compare
Commit that introduced the issue: ================================= odoo@e806328 Issue: ===== when an icon is converted to png it's cropped. Steps to reproduce the issue: ============================= - Go to this url: {host}/web_editor/font_to_img/61802/rgb(0,143,140)/rgb(255,255,255)/190x200 - The icon is cropped. Origin of the issue: ===================== In this case we are using `top` and `left` as they are the top left corner of the icon inside the image , but in reality the returned value is 0 , and the top left corner is represented by `box[0]` and `box[1]`. Solution: ========= Use of `box` values instead of `top` and `left` opw-3865845 X-original-commit: 07de2db
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 15, 2024
Commit that introduced the issue: ================================= e806328 Issue: ===== when an icon is converted to png it's cropped. Steps to reproduce the issue: ============================= - Go to this url: {host}/web_editor/font_to_img/61802/rgb(0,143,140)/rgb(255,255,255)/190x200 - The icon is cropped. Origin of the issue: ===================== In this case we are using `top` and `left` as they are the top left corner of the icon inside the image , but in reality the returned value is 0 , and the top left corner is represented by `box[0]` and `box[1]`. Solution: ========= Use of `box` values instead of `top` and `left` opw-3865845 closes #165273 X-original-commit: 07de2db Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit that introduced the issue:
e806328
Issue:
when an icon is converted to png it's cropped.
Steps to reproduce the issue:
Origin of the issue:
In this case we are using
topandleftas they are the top left corner of the icon inside the image , but in reality the returned value is 0 , and the top left corner is represented bybox[0]andbox[1].Solution:
Use of
boxvalues instead oftopandleftBefore:
After:
opw-3865845
Forward-Port-Of: #163006