[FW][FIX] mail: traceback when searching single quotes or round brackets

[fw-bot]

Before this commit, when trying to highlight a message containing a single quote you get a traceback.
To reproduce:

• post a message with body "can't"
• search for "can"
• search for "can't"

This happens because the XPath expression with unescaped single quotes becomes invalid.

This commit fixes the issue by escaping the single quotes using the XPath concat() function.

---

Before this commit, trying to search for a message containing a round bracket would produce a traceback.

• search for the string "("

This happens because the search term is not being escaped for the regexp.

This commit fixes the issue by escaping the search term. Same is being done on the mock server. Added tests.

Forward-Port-Of: #165121
Forward-Port-Of: #164320

[robodoo]

Pull request status dashboard.

[fw-bot]

@Atovange @alexkuhn cherrypicking of pull request #164320 failed.

stdout:

Auto-merging addons/mail/static/src/core/common/message_search_hook.js
CONFLICT (modify/delete): addons/mail/static/src/core/common/thread_service.js deleted in HEAD and modified in f0b3e1da2307 ([FIX] mail: escaping single quotes in message search).  Version f0b3e1da2307 ([FIX] mail: escaping single quotes in message search) of addons/mail/static/src/core/common/thread_service.js left in tree.
Auto-merging addons/web/static/src/core/domain.js
CONFLICT (content): Merge conflict in addons/web/static/src/core/domain.js

stderr:

18:53:44.783883 git.c:463               trace: built-in: git cherry-pick f0b3e1da2307cb5f9f613fdb93914789f866bcee
error: could not apply f0b3e1da2307... [FIX] mail: escaping single quotes in message search
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[alexkuhn]

@robodoo r+

[robodoo]

@alexkuhn you may want to rebuild or fix this PR as it has failed CI.

[alexkuhn]

@robodoo override=ci/security

This is just added comment on a side-effect of innerHTML= that is relevant for understanding that resulting message.body has a mix of escaped and non-escaped chars. The search term requires to be formatted the same way as a result.

#165121 (comment)