[FW][FIX] bus, im_livechat: fix non deterministic discuss sidebar test #165305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsm-odoo @alexkuhn cherrypicking of pull request #165204 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
Before this PR, the "unknown livechat can be displayed and interacted with" test was sometimes failing. This was due to a race condition between the sending of a message and the unpinning of the live chat channel. Specifically, the test removed the live chat from the discuss sidebar, but the channel remained pinned when the message was sent. If the live chat was unpinned before the reception of the new message notification, it remained in the sidebar, causing the test to fail. fixes runbot-61160 X-original-commit: e055c08
tsm-odoo
force-pushed
the
master-saas-17.2-mail-runbot_error_61160-tsm-On8o-fw
branch
from
2b3fc72
to
4d94727
Compare
|
@robodoo r+ |
C3POdoo
requested review from
a team,
aab-odoo,
kebeclibre and
Julien00859
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
May 14, 2024
Before this PR, the "unknown livechat can be displayed and interacted with" test was sometimes failing. This was due to a race condition between the sending of a message and the unpinning of the live chat channel. Specifically, the test removed the live chat from the discuss sidebar, but the channel remained pinned when the message was sent. If the live chat was unpinned before the reception of the new message notification, it remained in the sidebar, causing the test to fail. fixes runbot-61160 closes #165305 X-original-commit: e055c08 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
chevalierv
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 17, 2024
Before this PR, the "unknown livechat can be displayed and interacted with" test was sometimes failing. This was due to a race condition between the sending of a message and the unpinning of the live chat channel. Specifically, the test removed the live chat from the discuss sidebar, but the channel remained pinned when the message was sent. If the live chat was unpinned before the reception of the new message notification, it remained in the sidebar, causing the test to fail. fixes runbot-61160 closes odoo#165305 X-original-commit: e055c08 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
Before this PR, the "unknown livechat can be displayed and interacted with" test was sometimes failing. This was due to a race condition between the sending of a message and the unpinning of the live chat channel. Specifically, the test removed the live chat from the discuss sidebar, but the channel remained pinned when the message was sent. If the live chat was unpinned before the reception of the new message notification, it remained in the sidebar, causing the test to fail. fixes runbot-61160 closes odoo#165305 X-original-commit: e055c08 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the "unknown livechat can be displayed and interacted with" test was sometimes failing.
This was due to a race condition between the sending of a message and the unpinning of the live chat channel.
Specifically, the test removed the live chat from the discuss sidebar, but the channel remained pinned when the message was sent. If the live chat was unpinned before the reception of the new message notification, it remained in the sidebar, causing the test to fail.
fixes runbot-61160
Forward-Port-Of: #165204