[FIX] account: fix cross currency calculation while register payment #165325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team and
aliyatastemirova
and removed request for
a team
aliyatastemirova
requested changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
While registering for Payment in Invoice, if the company currency, the source currency of invoice and the payment currency of invoice; all the three are different, then the currency conversion to the payment currency was not accurate.
Current behavior before PR:
Before this PR, the conversion was directly made between the company currency and the payment currency.
Desired behavior after PR is merged:
This PR targets to change the currency conversion method. It now performs the conversion between the source currency of invoice and the payment currency. This will lead to accurate currency conversion as the exchange rate is correctly calculated now.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr