[FIX] website: link a new page to existing menus having same page url #165326
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step to reproduce:
1. Create a menu from menu editor. E.g.
Menu: test_menu
URL: /test (right now we don't have any page exist for this URL)
2. Create page with the same URL using New Page option.
Page title : test (let 'ADD to menu' button check)
3. Delete this page
- You will find test_menu is not delete while it's page gets
deleted
Currently, if menus were created before a page existed, they directly
link to the 'URL' as a string instead of a page ID. So when the page is
deleted later on, ondelete cascade won't be able to delete menus
automatically as they're not connected to the page ID.
To address this issue, this commit ensures that page ID are linked to
menus that share the same URL at the time of the creation of a new page.
Task-3757369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where menus created before a corresponding page existed wouldn't automatically delete when the page was removed. Previously, these menus were linked to the page's URL as a string instead of its pageID, preventing the automatic deletion through the ondelete cascade feature.
Steps to reproduce:
Menu: test_menu
URL: /test (right now we don't have any page for this URL).
Page title: test (let 'ADD to menu' button check)
You will find test_menu is not deleted while its page gets deleted.
Expected Behavior: The test_menu should also be deleted automatically, along with the associated page.
To address this issue, this PR ensures that pageID are linked to menus that share the same URL at the time of the creation of a new page.
Task-3757369