Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: update order's partner on InvoiceButton #165464

Closed

Conversation

mairasalazar
Copy link
Contributor

This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class InvoiceButton handles missing partners, writing the selected partner to pos.order. But since the partner was not set to the order, the JS client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order.

task-3865331


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented May 14, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label May 14, 2024
@mairasalazar mairasalazar force-pushed the 17.0-l10n_mx-cfdi-usage-pos-srma branch from cbae955 to 9b5eba6 Compare May 14, 2024 17:02
@mairasalazar mairasalazar marked this pull request as ready for review May 14, 2024 17:03
@C3POdoo C3POdoo requested review from a team and davidmonnom and removed request for a team May 14, 2024 17:06
@mairasalazar mairasalazar requested review from smetl and davidmonnom and removed request for davidmonnom May 14, 2024 19:54
Copy link
Contributor

@davidmonnom davidmonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@mairasalazar mairasalazar force-pushed the 17.0-l10n_mx-cfdi-usage-pos-srma branch 2 times, most recently from 1a8065d to 4c59648 Compare May 17, 2024 10:41
This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class
InvoiceButton handles missing partners, writing the selected partner
to pos.order. But since the partner was not set to the order, the JS
client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order

task-3865331
@mairasalazar mairasalazar force-pushed the 17.0-l10n_mx-cfdi-usage-pos-srma branch from 4c59648 to 6c32366 Compare May 17, 2024 12:06
@smetl
Copy link
Contributor

smetl commented May 21, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request May 21, 2024
This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class
InvoiceButton handles missing partners, writing the selected partner
to pos.order. But since the partner was not set to the order, the JS
client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order

task-3865331

closes #165464

Signed-off-by: Laurent Smet (las) <las@odoo.com>
robodoo pushed a commit that referenced this pull request May 21, 2024
This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class
InvoiceButton handles missing partners, writing the selected partner
to pos.order. But since the partner was not set to the order, the JS
client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order

task-3865331

closes #165464

Signed-off-by: Laurent Smet (las) <las@odoo.com>
robodoo pushed a commit that referenced this pull request May 21, 2024
This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class
InvoiceButton handles missing partners, writing the selected partner
to pos.order. But since the partner was not set to the order, the JS
client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order

task-3865331

closes #165464

Signed-off-by: Laurent Smet (las) <las@odoo.com>
@robodoo robodoo closed this in 580b812 May 22, 2024
@fw-bot
Copy link
Contributor

fw-bot commented May 25, 2024

@mairasalazar @smetl this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented May 26, 2024

@mairasalazar @smetl this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented May 27, 2024

@mairasalazar @smetl this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot deleted the 17.0-l10n_mx-cfdi-usage-pos-srma branch June 5, 2024 03:47
lohwswilson pushed a commit to lohwswilson/odoo that referenced this pull request Jun 5, 2024
This commit is used for the enterprise PR (odoo/enterprise#62261).

When creating an invoice for a previous order in the POS, the class
InvoiceButton handles missing partners, writing the selected partner
to pos.order. But since the partner was not set to the order, the JS
client cannot retrieve the partner directly.

This commit remedies that by setting the partner to the order

task-3865331

closes odoo#165464

Signed-off-by: Laurent Smet (las) <las@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants