[IMP] project_timesheet_holidays: improve Generate Timesheets Feature #165674
+49
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
suth-odoo
force-pushed
the
master-time-off-type-remove-project-task-ppr
branch
9 times, most recently
from
de5ec52
to
2a40a72
Compare
ppr-odoo
force-pushed
the
master-time-off-type-remove-project-task-ppr
branch
from
2a40a72
to
f71025b
Compare
ppr-odoo
changed the title
suth-odoo
force-pushed
the
master-time-off-type-remove-project-task-ppr
branch
6 times, most recently
from
7b9f1bf
to
b2f4bb1
Compare
Before this commit: By default, the current company is set on time off types. As such, the internal project of the current company is set. After this commit: This commit improves the functionality related to generating timesheets within the project_timesheet_holidays module. Specifically, it removes the association of projects and tasks from the time-off type and hides generated timesheets. Reason: if we set the company of the time off type to false, we either have: - no project -> meaning the user will disable the feature without realizing as the field is only visible in debug mode; - the internal project of the current company that remains set -> meaning the feature won't work for the other companies in which a time off request is created. task-3605962
suth-odoo
force-pushed
the
master-time-off-type-remove-project-task-ppr
branch
from
b2f4bb1
to
1348321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit:
By default, the current company is set on time off types. As such, the internal
project of the current company is set.
After this commit:
This commit improves the functionality related to generating timesheets within
the project_timesheet_holidays module. Specifically, it removes the association
of projects and tasks from the time-off type and hides generated timesheets.
Reason:
if we set the company of the time off type to false, we either have:
the field is only visible in debug mode;
meaning the feature won't work for the other companies in which a time off
request is created.
task-3605962