[IMP] base: remove redundant constraint check on ir.actions.server #165904
+0
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team,
xmo-odoo and
rco-odoo
and removed request for
a team
-Since [1] the value for evaluation_type no longer exists 'reference' and user can update m2m field using evaluation_type 'value' very dynamic therefore this commit remove redundant constraint check for evaluation_type 'reference'. 1: odoo@5ea3b8e
duong77476-viindoo
force-pushed
the
v17_imp_base_ir_actions_server
branch
from
806ebe0
to
ff6407d
Compare
|
Hello @kebeclibre Can you take a look ? i don't understand why the test failed, i only remove constraint sir |
|
Hello @bouvyd Can you take a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Since [1] the value for evaluation_type no longer exists 'reference' and user can update m2m field using evaluation_type 'value' very dynamic therefore this commit remove redundant constraint check for evaluation_type 'reference'
1: 5ea3b8e
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr