[IMP] hr_timesheet: portal sorting order when groupby date #165921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to fix the order of the timesheets in the portal view, when grouped by date with the sorting set by `newest. It also fixes the pagination not working properly when the timesheets are grouped by date. With this commit, when grouped by date, the timesheets will be sorted by latest when the sorting is set to `newest`, and by oldest when the sorting is set to other fields. Prior to this commit, when a user chose groupby `date` and sortby `newest`, on the protal view, the timesheets were returned by the oldest order. Additionally, the pagination was not working properly, because of how the timesheets were being aggregated. task-3770909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
This commit aims to fix the order of the timesheets in the portal view, when grouped by date with the sorting set by
newest. It also fixes the pagination not working properly when the timesheets are grouped by date. With this commit, when grouped by date, the timesheets will be sorted by latest when the sorting is set tonewest, and by oldest when the sorting is set to other fields (e.g. Employee, Project etc.)Current behavior before PR:
Prior to this commit, when a user chose groupby
dateand sortbynewest, on the protal view, the timesheets were returned by the oldest order. Additionally, the pagination was still reflecting data from the non-groupby timesheets, leading to a wrong number of pages shown when using the groupby date.task-3770909
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr