[FW][FIX] crm: make pls test independant of demo data #165938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all won / lost leads will have an impact on the PLS frequency table, demo data will have one on the probabilities of leads without team_id set, as their probability is based on all leads, regardless on their team. The demo data also creates entries in the frequency table as some leads are lost / won. Therefore, make sure we unlink all leads and frequencies in the setUpClass, to avoid any interference with demo data. One should create leads directly in their test. The models are flushed too to account for the deletion. Follow up of ecac497 Task-3700966 X-original-commit: c87da27
|
This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
As all won / lost leads will have an impact on the PLS frequency table, demo data will have one on the probabilities of leads without team_id set, as their probability is based on all leads, regardless on their team. The demo data also creates entries in the frequency table as some leads are lost / won. Therefore, make sure we unlink all leads and frequencies in the setUpClass, to avoid any interference with demo data. One should create leads directly in their test. The models are flushed too to account for the deletion. Follow up of ecac497 Task-3700966 closes #165938 X-original-commit: c87da27 Signed-off-by: Noé Antoine (nan) <nan@odoo.com> Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot
deleted the
saas-16.4-15.0-crm-fix_pls_test_demo_independant-nan-lcag-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all won / lost leads will have an impact on the PLS frequency table, demo data will have one
on the probabilities of leads without team_id set, as their probability is based on all leads, regardless on their team. Therefore, make sure we unlink all leads that are not the ones created in the test. We rebuild the table below, which is needed to ensure we only consider test leads.
Follow up of ecac497
Task-3700966
Forward-Port-Of: #165842
Forward-Port-Of: #162414