-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] mrp*,{purchase_,}stock: avoid route duplication #165949
Closed
fw-bot
wants to merge
1
commit into
odoo:saas-16.3
from
odoo-dev:saas-16.3-16.0-OPW-3888885-stock_route_duplication-awt-zbMp-fw
Closed
[FW][FIX] mrp*,{purchase_,}stock: avoid route duplication #165949
fw-bot
wants to merge
1
commit into
odoo:saas-16.3
from
odoo-dev:saas-16.3-16.0-OPW-3888885-stock_route_duplication-awt-zbMp-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@adwid @Whenrow cherrypicking of pull request #165728 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
This PR was created by @fw-bot
conflict
There was an error while creating this forward-port PR
labels
May 17, 2024
adwid
force-pushed
the
saas-16.3-16.0-OPW-3888885-stock_route_duplication-awt-zbMp-fw
branch
2 times, most recently
from
May 22, 2024 09:08
b27b984
to
1329caf
Compare
Few improvements for commit [1]: \- Before [1], `_find_global_route`, was not supposed to create any route. Let's keep it like that \- `_find_global_route` is sometimes calls with an empty `self` \- The name of the copied route should not contain "(Copy)" \- When looking for a route, we should skip the `active` criteria [1] 961ac2d OPW-3889889 OPW-3888885 X-original-commit: d1bdcde
adwid
force-pushed
the
saas-16.3-16.0-OPW-3888885-stock_route_duplication-awt-zbMp-fw
branch
from
May 22, 2024 09:18
1329caf
to
7a224cb
Compare
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 22, 2024
Few improvements for commit [1]: \- Before [1], `_find_global_route`, was not supposed to create any route. Let's keep it like that \- `_find_global_route` is sometimes calls with an empty `self` \- The name of the copied route should not contain "(Copy)" \- When looking for a route, we should skip the `active` criteria [1] 961ac2d OPW-3889889 OPW-3888885 closes #165949 X-original-commit: d1bdcde Signed-off-by: William Henrotin (whe) <whe@odoo.com> Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
fw-bot
deleted the
saas-16.3-16.0-OPW-3888885-stock_route_duplication-awt-zbMp-fw
branch
June 5, 2024 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
OE
the report is linked to a support ticket (opw-...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few improvements for commit [1]:
- Before [1],
_find_global_route
, was not supposed to create anyroute. Let's keep it like that
-
_find_global_route
is sometimes calls with an emptyself
- The name of the copied route should not contain "(Copy)"
- When looking for a route, we should skip the
active
criteria[1] 961ac2d
OPW-3889889
OPW-3888885
Forward-Port-Of: #165728