[FIX] mail, change _get_access_link to get the action id #16595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Sorry but I disagree. The actions using an external id should work fine. I confirm both id and xml id version works. Please elaborate on how to reproduce your bug. |
mart-e
added
the
Blocked
|
I've tested it now on runbot and it works well, so there must be something wrong in my server. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When sending an email, for example an invitation to follow a sale order, the address of the related document is wrong. Specifically, the action is the
xml_idinstead of an integer id. So the link is not working.Current behavior before PR:
An example of wrong url:
http://127.0.0.1:8069/web?db=odoo_test#action=mail.action_mail_redirect&login=admin%40odoo.com&res_id=35611&model=sale.orderDesired behavior after PR is merged:
The expected url:
http://127.0.0.1:8069/web?db=odoo_test#action=103&login=admin%40odoo.com&res_id=35611&model=sale.order--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr