[IMP] mail: make UI aware of first unread message #165973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
4 times, most recently
from
35043d3
to
6e0cbfa
Compare
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
6 times, most recently
from
409f713
to
384a028
Compare
tsm-odoo
changed the title
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
384a028
to
8c68468
Compare
tsm-odoo
changed the title
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
3 times, most recently
from
1cee8fd
to
b7ee458
Compare
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
2 times, most recently
from
f786d74
to
f81109b
Compare
alexkuhn
reviewed
May 17, 2024
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
f81109b
to
afc8e54
Compare
alexkuhn
reviewed
May 17, 2024
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
2 times, most recently
from
9e3c871
to
799c2ce
Compare
alexkuhn
reviewed
May 17, 2024
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
799c2ce
to
2fb7f14
Compare
alexkuhn
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
e2131ea
to
56ac256
Compare
seb-odoo
reviewed
May 17, 2024
seb-odoo
reviewed
May 17, 2024
alexkuhn
force-pushed
the
master-mail-improve_separator_state-tsm
branch
6 times, most recently
from
1dbdf91
to
2a623f6
Compare
alexkuhn
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
2a623f6
to
c7bfbc9
Compare
alexkuhn
changed the title
seb-odoo
approved these changes
May 17, 2024
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
2 times, most recently
from
9663bfc
to
9862809
Compare
|
Pushed to rebase and to fix an edge case (user didn't read any message). Before, we returned null meaning the new message separator was not displayed. Now, we return the first message. |
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
3 times, most recently
from
63d126c
to
8c8eea5
Compare
alexkuhn
approved these changes
May 21, 2024
|
@robodoo r+ |
This task aims at allowing the user to scroll to the first unread message. In order to do so, we need to determine which message is the first unread message. Until now, this information was only computed as part of the rendering process. This commit introduces this information as part of the thread model state instead. part of task-3551627
tsm-odoo
force-pushed
the
master-mail-improve_separator_state-tsm
branch
from
8c8eea5
to
19b7c2f
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
This task aims at allowing the user to scroll to the first unread message. In order to do so, we need to determine which message is the first unread message. Until now, this information was only computed as part of the rendering process. This commit introduces this information as part of the thread model state instead. part of task-3551627 closes #165973 Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
This task aims at allowing the user to scroll to the first unread message. In order to do so, we need to determine which message is the first unread message. Until now, this information was only computed as part of the rendering process. This commit introduces this information as part of the thread model state instead. part of task-3551627 closes odoo#165973 Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the new message separator was computed during rendering.
This task aims at allowing the user to scroll to the first unread
message. In order to do so, we need to determine which message is
the target of the new message separator.
This commit introduces this information as part of the thread model
state.
part of task-3551627