[FIX] test_http: adapt test to succeed with ubuntu 24.04 noble #165998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien00859
approved these changes
May 17, 2024
Comment on lines
25
to
28
| werkzeug_version = metadata.version('werkzeug') | ||
| if parse_version(werkzeug_version) >= parse_version('2.0.2') and parse_version(werkzeug_version) <= parse_version('3.0.1'): | ||
| # Bug in werkzeug from 2.2.0 up to 3.0.1 (shipped in Ubuntu Noble 24.04) | ||
| # Not a really big deal but should be remvoved once fixed upstream |
There was a problem hiding this comment.
Suggested change
| werkzeug_version = metadata.version('werkzeug') | |
| if parse_version(werkzeug_version) >= parse_version('2.0.2') and parse_version(werkzeug_version) <= parse_version('3.0.1'): | |
| # Bug in werkzeug from 2.2.0 up to 3.0.1 (shipped in Ubuntu Noble 24.04) | |
| # Not a really big deal but should be remvoved once fixed upstream | |
| werkzeug_version = metadata.version('werkzeug') | |
| if parse_version('2.0.2') <= parse_version(werkzeug_version) <= parse_version('3.0.1'): | |
| # Bug in werkzeug from 2.2.0 up to 3.0.1 (shipped in Ubuntu Noble 24.04) | |
| # not a big deal but should be removed once fixed upstream. |
There was a problem hiding this comment.
also change parse_version('2.0.2')
d-fence
force-pushed
the
16.0-remove-test-misc-redirect-moc
branch
from
c681ee9
to
81261cd
Compare
Julien00859
requested changes
May 17, 2024
The brand new Ubuntu Noble 24.04 ships python3-werkzeug 3.0.1. This versions has a bug [0] which leads to this test failing as double slashes get fixed by werkzeug even though `merge_slashes` parameter is set to False by default in Odoo. This should not have a big impact on real life but the test should be kept to ensure that the actual behavior of a 404 is not broken outside of Ubuntu Noble. So, with this commit, if the impacted version of werkzeug is used the test will not fail with a fixed url and a redirect response. The issue that exists from 2.2.0 up to 3.0.1 is fixed upstream [1] in 3.0.2. A bug report was filled in Ubuntu [2] (Debian is not impacted) [0]: pallets/werkzeug#2834 [1]: pallets/werkzeug#2860 [2]: https://bugs.launchpad.net/ubuntu/+source/python-werkzeug/+bug/2066041
d-fence
force-pushed
the
16.0-remove-test-misc-redirect-moc
branch
from
81261cd
to
27124a9
Compare
Nice catch (unlike parse_version('2.0.2') which was not really your catch) |
robodoo
pushed a commit
that referenced
this pull request
May 17, 2024
The brand new Ubuntu Noble 24.04 ships python3-werkzeug 3.0.1. This versions has a bug [0] which leads to this test failing as double slashes get fixed by werkzeug even though `merge_slashes` parameter is set to False by default in Odoo. This should not have a big impact on real life but the test should be kept to ensure that the actual behavior of a 404 is not broken outside of Ubuntu Noble. So, with this commit, if the impacted version of werkzeug is used the test will not fail with a fixed url and a redirect response. The issue that exists from 2.2.0 up to 3.0.1 is fixed upstream [1] in 3.0.2. A bug report was filled in Ubuntu [2] (Debian is not impacted) [0]: pallets/werkzeug#2834 [1]: pallets/werkzeug#2860 [2]: https://bugs.launchpad.net/ubuntu/+source/python-werkzeug/+bug/2066041 closes #165998 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
This was referenced May 17, 2024
|
@d-fence @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brand new Ubuntu Noble 24.04 ships python3-werkzeug 3.0.1. This versions has a bug 0 which leads to this test failing as double slashes get fixed by werkzeug even though
merge_slashesparameter is set to False by default in Odoo.This should not have a big impact on real life but the test should be kept to ensure that the actual behavior of a 404 is not broken outside of Ubuntu Noble.
So, with this commit, if the impacted version of werkzeug is used the test will not fail with a fixed url and a redirect response.
The issue that exists from 2.2.0 up to 3.0.1 is fixed upstream 1 in 3.0.2.
A bug report was filled in Ubuntu 2 (Debian is not impacted)