[FW][FIX] mail: show all attachment options #166094
Closed
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
forwardport
|
|
|
@reth-odoo cherrypicking of pull request #165332 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
reth-odoo
force-pushed
the
saas-17.2-17.0-show-all-attachment-options-when-deletable-reth-lezI-fw
branch
from
a3fc2ca
to
0d26a92
Compare
|
@robodoo r+ |
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. 1: 32a80a3 task-3519815 X-original-commit: 281140f
reth-odoo
force-pushed
the
saas-17.2-17.0-show-all-attachment-options-when-deletable-reth-lezI-fw
branch
from
0d26a92
to
f3daf5b
Compare
|
Can't use patchUserWithCleanup anymore because it's not in hoot, patching the pyenv setup method to get isAdmin which is even better anyway. @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 19, 2024
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. 1: 32a80a3 task-3519815 closes #166094 X-original-commit: 281140f Signed-off-by: Renaud Thiry (reth) <reth@odoo.com>
alexkuhn
reviewed
May 21, 2024
Comment on lines
+1173
to
+1193
| [ | ||
| 0, | ||
| 0, | ||
| { | ||
| mimetype: "image/jpeg", | ||
| name: "BLAH", | ||
| res_id: partnerId, | ||
| res_model: "res.partner", | ||
| }, | ||
| ], | ||
| [ | ||
| 0, | ||
| 0, | ||
| { | ||
| mimetype: "image/png", | ||
| name: "BLEH", | ||
| res_id: partnerId, | ||
| res_model: "res.partner", | ||
| }, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Could use Command.create(data) rather than [0, 0, data]
There was a problem hiding this comment.
Fair, could probably also have used a list comprehension to be honest in hindsight
fw-bot
deleted the
saas-17.2-17.0-show-all-attachment-options-when-deletable-reth-lezI-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template for the attachment list adds a class to show multiple options when attachments can be deleted.
However the condition to display the delete button is different from the condition to apply that style.
Meaning if one condition
showDeleteis true while the otherisDeletableis false it is impossible to access the download button as the correct style is not applied.Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously.
Steps to reproduce:
1: 32a80a3
task-3519815
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #166086
Forward-Port-Of: #165332