Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: include archived records when exporting grouped results #166097

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

nd-dew
Copy link
Contributor

@nd-dew nd-dew commented May 19, 2024

When exporting non-grouped records we include archived records in results, this commits makes grouped results consiste with that, i.e. now also grouped records will include archived results

[Reproduce]

  • Install crm
  • Go to: crm app
    • Switch to List view
    • Remove all filters
    • Use filter "Lost"
    • Group by "Stage"
    • Select all and Export -> BUG: exported xlsx file is empty

Note: Above we have a specyfic case, to generalize that steps we can say, that whenever we filter with "Lost" and use whatever "group by" then export is empty

opw-3901258

@robodoo
Copy link
Contributor

robodoo commented May 19, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 19, 2024
@nd-dew nd-dew force-pushed the 15.0-opw-3901258-exporting_grouped_includes_archived-pian branch from e22c8e9 to 9c36d88 Compare May 21, 2024 09:47
Copy link
Contributor

@nle-odoo nle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

addons/web/controllers/main.py Outdated Show resolved Hide resolved
When exporting non-grouped -> archived records are included in the results,
when exporting grouped -> archived records are not included in the results.

This commit makes behaviour consistent between exporting grouped and non-grouped.
Now grouped records will include archived results (same as non-grouped)

[Reproduce]
- Install crm
- Go to: crm app
	- Switch to List view
	- Remove all filters
	- Use filter "Lost"
	- Group by "Stage"
	- Select all and Export -> BUG: exported xlsx file is empty

Note: Above we have a specyfic case, to generalize that steps we can say,
that whenever we filter with "Lost" and use whatever "group by" then export is empty

opw-3901258
@nd-dew nd-dew force-pushed the 15.0-opw-3901258-exporting_grouped_includes_archived-pian branch from 9c36d88 to 0c46a89 Compare May 21, 2024 14:07
@nd-dew nd-dew marked this pull request as ready for review May 21, 2024 14:41
@C3POdoo C3POdoo requested review from a team, xmo-odoo, rco-odoo, juliusc2066, BastienFafchamps and Julien00859 and removed request for a team May 21, 2024 14:46
Copy link
Member

@rco-odoo rco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants