[IMP] l10n_in: raise warning for incorrect GST tax selection on overseas invoices #166109
Conversation
|
|
dhad-odoo
force-pushed
the
master-l10n_in-imp-gst_tax_selection_on_overseas_invoice-dhad
branch
2 times, most recently
from
14d539d
to
add7932
Compare
dhad-odoo
force-pushed
the
master-l10n_in-imp-gst_tax_selection_on_overseas_invoice-dhad
branch
2 times, most recently
from
990c0ce
to
516d428
Compare
|
Thanks for the feedback, @dbkosky Please review the changes. |
| @api.depends('invoice_line_ids.tax_ids', 'l10n_in_gst_treatment', 'l10n_in_state_id.code') | ||
| def _compute_l10n_in_warnings(self): | ||
| for move in self: | ||
| if move.country_code != 'IN': |
There was a problem hiding this comment.
Why country_code is not a dependency?
| not self.env.ref('l10n_in.tax_tag_igst') in tax.invoice_repartition_line_ids.tag_ids | ||
| for tax in move.invoice_line_ids.tax_ids.filtered(lambda tax: tax.country_code == 'IN') |
There was a problem hiding this comment.
Multiple things to say here:
Avoid doing a double loop here (your list comprehension and the filtered function).
Instead do something like this:
x = [
a
for a in my_list
if a.country_code == 'IN'
]After, avoid using .ref() in a loop, each time, you'll browse and call exists on the same new object. Save it in a variable before entering in your list comprehension.
Finally, instead of doing the not self.env.ref('l10n_in.tax_tag_igst') in tax.invoice_repartition_line_ids.tag_ids, inverse it for something like this:
self.env.ref('l10n_in.tax_tag_igst') not in tax.invoice_repartition_line_ids.tag_idsThere was a problem hiding this comment.
I have updated the code according to the last-minute feedback from the product owner for improved functionality. I will incorporate the changes you mentioned and push the new code soon. @FlorianGilbert
Thank you
dhad-odoo
force-pushed
the
master-l10n_in-imp-gst_tax_selection_on_overseas_invoice-dhad
branch
2 times, most recently
from
ce43d8e
to
faa507b
Compare
…eas invoices Before this commit: When users selected incorrect Tax for exports where the 'place of supply' is 'Foregin Country(IN)' and the GST Treatment Type was set to Overseas, GSTR-1 did not compute the values. This caused difficulties for customers in tracing transactions that were not captured in GSTR-1. After this commit: Introduced a non-blocking warning banner on the account.move (invoice) when the GST Treatment is Overseas, place of supply is 'Foregin Country(IN)' and the selected tax is not IGST. This helps users identify and correct tax selection issues, ensuring accurate capture of transactions in GSTR-1. Task ID - 3921997
dhad-odoo
force-pushed
the
master-l10n_in-imp-gst_tax_selection_on_overseas_invoice-dhad
branch
from
faa507b
to
3c80afd
Compare
|
@FlorianGilbert , I have added the test case and made the changes you mentioned. |
|
According to @tsb-odoo comment on the task, we won't merge this PR. Feel free to open it again if PO change their mind. |
Before this PR:
When users selected incorrect Tax for exports where the 'place of supply' is 'Foregin Country(IN)' and the GST Treatment Type was set to Overseas, GSTR-1 did not compute the values. This caused difficulties for customers in tracing transactions that were not captured in GSTR-1.
After this PR:
Introduced a non-blocking warning banner on the account.move (invoice) when the GST Treatment is Overseas and the selected tax is not IGST. This helps users identify and correct tax selection issues, ensuring accurate capture of transactions in GSTR-1.
Task ID: 3921997