Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: same format for all _get_invoiced_lot_values #166120

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 20, 2024

_get_invoiced_lot_values in module sale_stock returns a key lot_id.

res.append({
'product_name': lot.product_id.display_name,
'quantity': formatLang(self.env, invoiced_lot_qty, dp='Product Unit of Measure'),
'uom_name': lot.product_uom_id.name,
'lot_name': lot.name,
# The lot id is needed by localizations to inherit the method and add custom fields on the invoice's report.
'lot_id': lot.id,
})

All related methods should do the same, for coherence and easier inherit

opw-3847889


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #165035

_get_invoiced_lot_values in module sale_stock returns a key lot_id.

All related methods should do the same, for coherence and easier inherit

opw-3847889

X-original-commit: 0a0c931
@robodoo
Copy link
Contributor

robodoo commented May 20, 2024

Pull request status dashboard.

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 20, 2024
@nda-odoo
Copy link
Contributor

@fw-bot r+

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 20, 2024
robodoo pushed a commit that referenced this pull request May 20, 2024
_get_invoiced_lot_values in module sale_stock returns a key lot_id.

All related methods should do the same, for coherence and easier inherit

opw-3847889

closes #166120

X-original-commit: 0a0c931
Related: odoo/enterprise#62834
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Nicolas Danhier (nda) <nda@odoo.com>
@robodoo robodoo closed this May 20, 2024
@robodoo robodoo added the 17.3 label May 20, 2024
zel-odoo pushed a commit to odoo-dev/odoo that referenced this pull request May 24, 2024
_get_invoiced_lot_values in module sale_stock returns a key lot_id.

All related methods should do the same, for coherence and easier inherit

opw-3847889

closes odoo#166120

X-original-commit: 0a0c931
Related: odoo/enterprise#62834
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Nicolas Danhier (nda) <nda@odoo.com>
@fw-bot fw-bot deleted the master-15.0-_get_invoiced_lot_values-lot-id-nda-XGtV-fw branch June 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants