Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base: fr translation corrupted import datetime error message #16663

Conversation

bplancher
Copy link

@bplancher bplancher commented Apr 26, 2017

Description of the issue/feature this PR addresses:

When importing data, datetime related errors are corrupted by FR translation.

The source string contains %%(field)s variable, but fr translation changed it to %%(fields)s.
This causes weird error : KeyError : u'fields'
This fix only rename variable to %%(field)s in the FR datetime message.

Current behavior before PR:
When importing data, when a datetime related error is raised, we only see u'fields' on the displayed error messages, nothing more useful.

Desired behavior after PR is merged:
When importing data, when a datetime related error is raised, we see the real error : MM/DD/YYYY does not seem to be a valid datetime for field FIELD on the displayed error messages.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

When importing data, datetime related errors are corrupted by FR translation.

The source string contains %%(field)s variable, but fr translation changed it to %%(fields)s.
This causes weird error : KeyError : u'fields'

This fix only rename variable to %%(field)s in the FR datetime message.
@mart-e
Copy link
Contributor

mart-e commented Apr 26, 2017

Hello,

Thanks for the contribution but please check translation documentation, the translations are handled on Transifex, not Github.

Please submit your changes there and let me know if you have issues.

Thanks

@mart-e mart-e closed this Apr 26, 2017
@bplancher
Copy link
Author

Hello,

Thanks for your reply.
I added the suggestion on your FR Transifex project.

Have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants