[FIX] account: it was possible to change the reconcile flag in not permitted case #17437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you noticed Florent, this PR is superseeded by #19204 So for the sake of clarity I'm closing this PR Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
It is wrong because you have entries renconcllied in account where the reconciliation is not allowed. (And after save, Odoo make a long computation, it seems not the behavior because the author write
# If user change the reconcile flag, all aml should be recomputed for that account and this is very costly.).Version impacted : master,10,9
Current behavior before PR:
It was possible to change True to False the reconcile flag, even if there are some entries. Because the test
if vals.get('reconcile'):is not correct.Desired behavior after PR is merged:
It is not possible to set False if there are entries.
It is possible to set False if there are not entries.
It is possible to set True if there are entries or not (after reading of code, it seems not an issue to set False to True if there are some entries.)
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr