Master crm expected revenue kme #18786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kme-odoo
force-pushed
the
master-crm_expected_revenue-kme
branch
from
d5984ae
to
d42a3da
Compare
tivisse
reviewed
Oct 18, 2017
addons/crm/models/crm_lead.py
Outdated
| date_deadline = fields.Date('Expected Closing', help="Estimate of the date on which the opportunity will be won.") | ||
| color = fields.Integer('Color Index', default=0) | ||
| partner_address_name = fields.Char('Partner Contact Name', related='partner_id.name', readonly=True) | ||
| partner_address_email = fields.Char('Partner Contact Email', related='partner_id.email', readonly=True) | ||
| company_currency = fields.Many2one(string='Currency', related='company_id.currency_id', readonly=True, relation="res.currency") |
There was a problem hiding this comment.
A default value on a related field seems useless.
Is it intended ?
tivisse
force-pushed
the
master-crm_expected_revenue-kme
branch
from
d42a3da
to
ddd8176
Compare
Purpose ======= Expected revenue field on pop up have no any indication of currency due to that people enter a dollar sign in the field. Eg: $1234 then an error appears when trying to save saying that the field is invalid but the user doesn’t know why. If the currency symbol was displayed it would solve the problem. Specification ============= 'Expected Revenue' field on wizard should be monetary in order to display the currency symbol.
tivisse
force-pushed
the
master-crm_expected_revenue-kme
branch
from
ddd8176
to
733306f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : https://www.odoo.com/web#id=35750&view_type=form&model=project.task&action=327&menu_id=4720
Pad : https://pad.odoo.com/p/r.8823669765e97912331f5eff769409c6
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr