[ADD] account: compute taxes line on account.move with onchange #19029

smetl · 2017-08-24T06:58:51Z

Allow the user to set taxes on lines when creating a new account.move.

task: https://www.odoo.com/web#id=33802&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

nhomar · 2017-08-24T07:55:04Z

I will never understand WHY you guys insists on create this feature on view level when this is at model level (this an old topic).

I am glad this feature is comming up, But IMHO, this must be a model aware feature, I mean it does not matter where the move line comes from if you wire a tax this must happen at model level also (may be a create/write overwrite with an update process).

With that even API level this will be consistent.

qdp-odoo · 2017-11-15T08:51:02Z

addons/account/models/account_move.py

@@ -446,6 +492,7 @@ def _get_counterpart(self):
    analytic_tag_ids = fields.Many2many('account.analytic.tag', string='Analytic tags')
    company_id = fields.Many2one('res.company', related='account_id.company_id', string='Company', store=True)
    counterpart = fields.Char("Counterpart", compute='_get_counterpart', help="Compute the counter part accounts of this journal item for this journal entry. This can be needed in reports.")
+    is_tax_line = fields.Boolean(string='Is a tax line')


useless field: use "tax_line_id is True" instead

qdp-odoo · 2017-11-15T08:52:10Z

addons/account/models/account_move.py

+        line with 150 debit.
+        '''
+        # Retrieve the existing tax lines and drop them.
+        tax_line_ids = self.line_ids.filtered(lambda l: l.is_tax_line)


I don't remember well but it was the only way I found to avoid some problems when dealing with real ids on db + 'fake ids' corresponding to newly created (but not committed) lines... to recheck!

qdp-odoo

changes needed

qdp-odoo · 2018-05-25T15:24:20Z

addons/account/tests/test_account_move_taxes_edition.py

+
+@tagged('post_install', '-at_install')
+class TestAccountMoveTaxesEdition(AccountingTestCase):
+    def _check_move_lines_taxes(self, lines):


use check_complete_move(self, move, theorical_lines) defined in AccountingTestCase.

adapt that function in order to allow testing of any columns (currently only name, debit, credit are tested but we need tax_ids and tax_line_id as well)

Then, later in the test, use a tax that you create yourself so that you're sure of the rate and and tax amount

qdp-odoo · 2018-05-25T16:02:00Z

addons/account/tests/test_account_move_taxes_edition.py

+
+            amount = tax.compute_all(2000)['total_included']
+
+            with move_form.line_ids.new() as credit_line2:


that last part of the 3th test is unclear.

So far, you should have

Name debit credit tax_ids tax_line_id

debit line 1 1000 10%

tax line 105 10%

credit line 1 1105

When adding the second debit line, assert the debit amount of tax line is set to 300 and assert the number of lines is now 4 (no fifth line added)

Then set the last credit line 2 manually to (3300 - 1105) and check the whole move is now

Name debit credit tax_ids tax_line_id

debit line 1 1000 10%

tax line 300 10%

credit line 1 1105

debit line 2 2000 10%

credit line 2 2195

qdp-odoo · 2018-05-25T16:07:48Z

addons/account/models/account_move.py

+        def _get_tax_account(tax, amount):
+            if tax.tax_exigibility == 'on_payment' and tax.cash_basis_account:
+                return tax.cash_basis_account
+            return tax.refund_account_id if amount < 0 else tax.account_id


mmh that part is dubious: a tax line being a credit is a regular sale tax line, or a refund purchase tax line. I don't think it'll work as, somehow, you need to consider the type of tax used, I guess

qdp-odoo · 2018-05-30T08:30:50Z

addons/account/tests/account_test_classes.py

@@ -21,15 +22,73 @@ def setUp(self):
            _logger.warn('Test skipped because there is no chart of account defined ...')
            self.skipTest("No Chart of account found")

-    def check_complete_move(self, move, theorical_lines):
+    def check_complete_move(self, move, theorical_lines, fields_name=None):


sorry, I was not clear on my first comment :-s

theorical_lines should be a list of dict, and move should be a recordset of account.move.line, that would be much more convenient.

The idea is, in a next iteration, to remove codes doing similar thing such as check_results() in test_reconciliation.py or check_journal_items() in test_payment.py

Actually, the parameter fields_name is useless as it can be deducted from theorical_lines[0].keys()

Can you change that?

Done in last commit

stuff moved to #25129

Allow the user to set taxes on lines when creating a new account.move. task: https://www.odoo.com/web#id=33802&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

Allow the user to set taxes on lines when creating manually a new journal entry, and tax lines will be computed automatically thanks to an onchange based on new unstored fields. Was task: 33802 Was PR odoo#19029

qdp-odoo · 2018-06-08T12:36:51Z

landed in master, for saas 11.4, at revision d49ab56

Allow the user to set taxes on lines when creating manually a new journal entry, and tax lines will be computed automatically thanks to an onchange based on new unstored fields. Was task: 33802 Was PR odoo#19029

smetl added Accounting RD research & development, internal work labels Aug 24, 2017

smetl requested a review from qdp-odoo August 24, 2017 06:58

smetl force-pushed the master-tax-jour-las branch from de77670 to 33f2674 Compare August 31, 2017 13:38

qdp-odoo requested changes Nov 15, 2017

View reviewed changes

smetl force-pushed the master-tax-jour-las branch 2 times, most recently from 9dc4e0c to f88d641 Compare November 15, 2017 12:52

smetl force-pushed the master-tax-jour-las branch from f88d641 to 94759c7 Compare December 20, 2017 08:59

smetl force-pushed the master-tax-jour-las branch from 94759c7 to c598b05 Compare January 4, 2018 13:59

smetl force-pushed the master-tax-jour-las branch from c598b05 to db1da3c Compare January 30, 2018 08:32

smetl force-pushed the master-tax-jour-las branch from 0496e92 to 90ce546 Compare March 20, 2018 10:14

smetl force-pushed the master-tax-jour-las branch 2 times, most recently from 17dc277 to 6303c25 Compare April 3, 2018 13:57

smetl force-pushed the master-tax-jour-las branch from 6303c25 to 4b1be93 Compare April 19, 2018 10:01

smetl force-pushed the master-tax-jour-las branch from 4b1be93 to 0c21a38 Compare May 7, 2018 12:29

qdp-odoo requested changes May 25, 2018

View reviewed changes

smetl force-pushed the master-tax-jour-las branch from 779eb39 to c05cd93 Compare May 28, 2018 13:16

qdp-odoo reviewed May 30, 2018

View reviewed changes

smetl force-pushed the master-tax-jour-las branch 3 times, most recently from ba7463c to af1e210 Compare June 7, 2018 07:23

smetl and others added 2 commits June 8, 2018 11:26

[ADD] account: compute taxes line on account.move with onchange

a6efe6d

Allow the user to set taxes on lines when creating a new account.move. task: https://www.odoo.com/web#id=33802&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

[FIX] refund account based on type_tax_use

9bc2bcf

smetl force-pushed the master-tax-jour-las branch from d108feb to 9bc2bcf Compare June 8, 2018 09:30

qdp-odoo closed this Jun 8, 2018

smetl deleted the master-tax-jour-las branch November 6, 2018 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] account: compute taxes line on account.move with onchange #19029

[ADD] account: compute taxes line on account.move with onchange #19029

smetl commented Aug 24, 2017 •

edited

nhomar commented Aug 24, 2017

qdp-odoo Nov 15, 2017

qdp-odoo Nov 15, 2017

smetl Nov 15, 2017

qdp-odoo left a comment

qdp-odoo May 25, 2018

qdp-odoo May 25, 2018

qdp-odoo May 25, 2018

qdp-odoo May 30, 2018

smetl May 30, 2018

smetl Jun 8, 2018

qdp-odoo commented Jun 8, 2018


		amount = tax.compute_all(2000)['total_included']

		with move_form.line_ids.new() as credit_line2:

Name	debit	credit	tax_ids	tax_line_id
debit line 1	1000		10%
tax line	300			10%
credit line 1		1105
debit line 2	2000		10%
credit line 2		2195

[ADD] account: compute taxes line on account.move with onchange #19029

[ADD] account: compute taxes line on account.move with onchange #19029

Conversation

smetl commented Aug 24, 2017 • edited

task: https://www.odoo.com/web#id=33802&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

nhomar commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qdp-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qdp-odoo commented Jun 8, 2018

smetl commented Aug 24, 2017 •

edited