Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n ma one tag per grid ptr #19058

Merged
merged 0 commits into from Jan 3, 2019
Merged

l10n ma one tag per grid ptr #19058

merged 0 commits into from Jan 3, 2019

Conversation

qdp-odoo
Copy link
Contributor

@qdp-odoo qdp-odoo commented Aug 25, 2017 •
edited by hmo-odoo

@C3POdoo C3POdoo added the RD research & development, internal work label Sep 13, 2017
@rop-odoo rop-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch from da7325d to f6ea313 Compare November 3, 2017 13:59
@hmo-odoo hmo-odoo changed the base branch from master to 9.0 November 3, 2017 14:02
@hmo-odoo hmo-odoo changed the base branch from 9.0 to master November 7, 2017 10:34
@rop-odoo rop-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch 3 times, most recently from 70b6378 to 36b0d59 Compare November 7, 2017 12:35
@rop-odoo rop-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch from 36b0d59 to 62954cf Compare November 16, 2017 13:32
oco-odoo
oco-odoo requested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless tags need to be removed.

addons/l10n_ma/data/account_tax_data.xml Outdated
<field name="name">Ventilation du chiffre d’affaires imposable</field>
<field name="applicability">taxes</field>
</record>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining tags for report lines that do not use them makes no sense. Please remove them ;)

@hmo-odoo hmo-odoo added the Localization about adapting the content to a specify country (usually chart of accounts) label Mar 20, 2018
@dat-odoo dat-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch 4 times, most recently from 4b10740 to 8b66b75 Compare March 27, 2018 08:41
@rgo-odoo rgo-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch from 8b66b75 to c098bc8 Compare April 18, 2018 13:52
@dat-odoo dat-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch from c098bc8 to 2d4b1c2 Compare April 25, 2018 05:35
dat-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Apr 25, 2018
@ptr-odoo @dat-odoo
[IMP] l10n_ma: better tags for taxes
2d4b1c2 
created new tags and assign them in taxes

was task# 22559
was PR odoo#19058
@dat-odoo dat-odoo force-pushed the 9.0-l10n_ma_one-tag-per-grid-ptr branch from 2d4b1c2 to 3e9102b Compare January 3, 2019 09:10
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 3, 2019
@robodoo robodoo merged commit 3e9102b into odoo:master Jan 3, 2019
@robodoo robodoo added closed 💔 and removed CI 🤖 Robodoo has seen passing statuses labels Jan 3, 2019
@dat-odoo dat-odoo mentioned this pull request Jan 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oco-odoo oco-odoo oco-odoo requested changes

Assignees
No one assigned
Labels
Localization about adapting the content to a specify country (usually chart of accounts) RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qdp-odoo @oco-odoo @hmo-odoo @C3POdoo @robodoo