Fix bank graph in case statements are not in order #20987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the output from PSQL does not provide dates in order, the calculation mode used to build the line graph reports wrong results. This is fixed by ordering output from DB by adding an ORDER BY clause.
|
Solved in parallel by #29936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the output from PSQL does not provide dates in order, the calculation mode used to build the line graph reports wrong results.
This is fixed by ordering output from DB by adding an ORDER BY clause.
Description of the issue/feature this PR addresses: Line graph in Accounting / Dashboard for bank accounts
Current behavior before PR: In case the output from PSQL does not provide dates in order, the calculation mode used to build the line graph reports wrong results and the graph becomes useless since all bank statements outputs are mixed up.
Desired behavior after PR is merged: Get a proper bank flow graph
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr