Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][FIX] Correct check of property 'rules' #22603

Closed
wants to merge 1 commit into from
Closed

Conversation

MouTio
Copy link
Contributor

@MouTio MouTio commented Jan 29, 2018

Description of the issue/feature this PR addresses:
#22517

Current behavior before PR:
In some browsers, like Chrome 64, there is an exception when the property 'rules' is not located in CSS sheets and the user tries to enter to some sections, like 'Preferences'.

Desired behavior after PR is merged:
'rules' property is correctly checked and the execution continues in every browsers.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MouTio MouTio changed the title [FIX] Correct check of property 'rules' [9.0][FIX] Correct check of property 'rules' Jan 30, 2018
@MouTio MouTio closed this Jan 31, 2018
@MouTio MouTio deleted the patch-1 branch January 31, 2018 09:38
@MouTio MouTio restored the patch-1 branch January 31, 2018 09:40
@MouTio MouTio reopened this Jan 31, 2018
@leemannd
Copy link
Contributor

leemannd commented Feb 2, 2018

Thanks for the fix

ged-odoo pushed a commit that referenced this pull request Feb 5, 2018
@ged-odoo
Copy link
Contributor

ged-odoo commented Feb 5, 2018

I couldn't accept this PR because the CLA check did not pass. However, I just pushed a fix in 9.0. Thank you for your contribution

@ged-odoo ged-odoo closed this Feb 5, 2018
@MouTio
Copy link
Contributor Author

MouTio commented Feb 5, 2018

@ged-odoo I don't know why the CLA check did not pass.

I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

And it is commited in 8c941cb (Jan 31, 2018 of branch 9.0)

@traviswaelbro
Copy link
Contributor

@ged-odoo @MouTio I've had a similar issue with CLA failing for no apparent reason, so I would be interested to know why as well.

@ged-odoo
Copy link
Contributor

ged-odoo commented Feb 5, 2018

that is curious indeed. Sorry for that, I'll have a better look next time the issue arises

@aryeharmon
Copy link

hasOwnProperty('rules') always returns false

@MouTio
Copy link
Contributor Author

MouTio commented Feb 6, 2018

@aryeharmon yes. That is because there is no property 'rules'. Anyway, the BUG here was the check of that property. The existance or not of the property is another matter.

@MouTio MouTio deleted the patch-1 branch May 8, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants