New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][FIX] Correct check of property 'rules' #22603
Conversation
Thanks for the fix |
I couldn't accept this PR because the CLA check did not pass. However, I just pushed a fix in 9.0. Thank you for your contribution |
@ged-odoo I don't know why the CLA check did not pass. I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr And it is commited in 8c941cb (Jan 31, 2018 of branch 9.0) |
that is curious indeed. Sorry for that, I'll have a better look next time the issue arises |
hasOwnProperty('rules') always returns false |
@aryeharmon yes. That is because there is no property 'rules'. Anyway, the BUG here was the check of that property. The existance or not of the property is another matter. |
Description of the issue/feature this PR addresses:
#22517
Current behavior before PR:
In some browsers, like Chrome 64, there is an exception when the property 'rules' is not located in CSS sheets and the user tries to enter to some sections, like 'Preferences'.
Desired behavior after PR is merged:
'rules' property is correctly checked and the execution continues in every browsers.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr