service/db: [IMP] add set user timezone in unambigous cases #23077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the company's country has only onw time zone it is more often than not true, that the users of this database will also use the single timezone of the main company.
blaggacao
force-pushed
the
db-service-set-user-timzone
branch
from
4b144d6
to
840b546
Compare
|
Test fail unrelated... |
mart-e
reviewed
Mar 20, 2018
| @@ -72,6 +73,10 @@ def _initialize_db(id, db_name, demo, lang, user_password, login='admin', countr | |||
| countries = env['res.country'].search([('code', 'ilike', country_code)]) | |||
| if countries: | |||
| env['res.company'].browse(1).country_id = countries[0] | |||
| if len(country_timezones[country_code]) == 1: | |||
| users = env['res.users'].search(['|', ('active','=', True), ('active','=', False)]) | |||
There was a problem hiding this comment.
You could use active_test context key to do so but I do not think it is a good idea anyway. Just leave no tz for the inactive users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no better description than the commit message.
/cc @odony
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When the company's country has only onw time zone it is more often
than not true, that the users of this database will also use the
single timezone of the main company.