Layout issue with oe_inline #23914
Closed
Layout issue with oe_inline #23914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vas-odoo
force-pushed
the
master-web-selection-field-vas
branch
2 times, most recently
from
0a8a1d6
to
89d016f
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
2344bcd
to
9f7b842
Compare
vas-odoo
force-pushed
the
master-web-selection-field-vas
branch
2 times, most recently
from
4dd449f
to
a9ed072
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
a9ed072
to
aa67069
Compare
vas-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
aa67069
to
f64476c
Compare
vas-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
f64476c
to
eea2792
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
eea2792
to
decbe43
Compare
robodoo
added
CI 🤖
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
decbe43
to
276ad94
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
b182449
to
12821e4
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
12821e4
to
931a381
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
7 times, most recently
from
ab8b0d5
to
291f5b2
Compare
|
@qsm-odoo done changes in commit message |
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
291f5b2
to
4e2cec8
Compare
msh-odoo
force-pushed
the
master-web-selection-field-vas
branch
from
4e2cec8
to
7e24931
Compare
This will fix UI glitch for fields added in form view side by side to get fields on same line and also to get space between two fields use o_row oe_inline is used to put two elements on same line but it is used mostly where 1 element is field and second one is static string maybe in span, oe_inline on two field creates glitch in UI, to have two fields or divs on same line we should use o_row class, o_row class meant to do that task-31003
This commit will fix UI glitch when seletion field and any other field kept on same line Using o_row we can put two divs, two inputs side by side but if we have case where from two elements 1 is input and second one is selection widget then we will have glitches in UI, this commit will fix that glitch task-31003
|
@qsm-odoo I hope you'll be happy now |
|
Merge method set to rebase and fast-forward |
|
Linked pull request(s) odoo/enterprise#2087 not ready. Linked PRs are not staged until all of them are ready. |
|
@robodoo retry |
|
I'm sorry, @JKE-be. Retry makes no sense when the PR is not in error. |
pniederlag
pushed a commit
to pniederlag/odoo
that referenced
this pull request
Apr 21, 2019
This commit will fix UI glitch when seletion field and any other field kept on same line Using o_row we can put two divs, two inputs side by side but if we have case where from two elements 1 is input and second one is selection widget then we will have glitches in UI, this commit will fix that glitch task-31003 closes odoo#23914 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://www.odoo.com/web#id=31003&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
Pad: https://pad.odoo.com/p/r.631015720100a9d380f3446249f0daf9
Glitch is created because input element will have padding of 1px while select element will not have any padding, so to have right alignment added 1px padding on the select element(let's keep padding on input element and make select element aligned with input)