New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master stock logistics improvement nsa #23921
Master stock logistics improvement nsa #23921
Conversation
addons/uom/models/uom_uom.py
Outdated
@@ -41,7 +41,7 @@ class UoM(models.Model): | |||
|
|||
_sql_constraints = [ | |||
('factor_gt_zero', 'CHECK (factor!=0)', 'The conversion ratio for a unit of measure cannot be 0!'), | |||
('rounding_gt_zero', 'CHECK (rounding>0)', 'The rounding precision must be greater than 0!') | |||
('rounding_gt_zero', 'CHECK (rounding!=0)', 'The rounding precision must be strictly positive.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't get it
0.000 should not pass the original "rounding_gt_zero" constraint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsa-odoo No need to change this it will work what as it is ( rounding > 0 ) just change message ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the original feedback is there because we're able to set a rounding of 0.000
can you double check this usecase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the original feedback is there because we're able to set a rounding of 0.000
can you double check this usecase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sle-odoo When you set rounding 0.000 , it will raise warning but when you close the warning view not reloaded and its not going to change a value in cache,
And default value of rounding is 0.01 , so system not giving warning second time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sle-odoo
it's not producible everytime...
https://drive.google.com/open?id=1R8LC2PWmuRPjKzWIdnbWLhvrt3AmqZAj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20e6ae8
to
0592ce4
Compare
1b5b318
to
4d1e3c2
Compare
9018e40
to
5eee81e
Compare
5c8ecf4
to
d1411dc
Compare
…nder". We changed the name of purchase requisition type "Purchase tender" by "Call for Tender" TASK-60709.
We generate a better message when a product is unbuilt and has components tracked. TASK-60709
When an uom is created with a rounding of 0.0, an error message is triggered, we improved this message. TASK-60709
When all quants in a package have the same owner and/or company, the field owner and/or company on quant_package will have the same value as the one on quants. TASK-60709
d1411dc
to
e01620c
Compare
Description of the issue/feature this PR addresses:
task : https://www.odoo.com/web#id=60709&view_type=form&model=project.task&menu_id=4720
pad : https://pad.odoo.com/p/r.7de8a4f31d83d37680c63751c2594075
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr