[IMP] base: do not set a value for new translations #24391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-e
added
RD
mart-e
force-pushed
the
master-insert-new-trad-no-value-mat
branch
from
1a6c558
to
5887a6c
Compare
d-fence
approved these changes
Sep 3, 2018
When generating new translations (e.g. 'edit translations' button on a view or on a translatable field), the new generated translations have the source as translation value. Set the state to 'to_translate' as it is the default value This change requires to add a fallback in web_editor when computing translated dom When a translation has no value, there is a fallback done in the different translation method (e.g. xml_translate) but, as the node was manually created in edit_translation_mapping, the fallback was missing
d-fence
previously requested changes
Sep 4, 2018
mart-e
force-pushed
the
master-insert-new-trad-no-value-mat
branch
from
8055fb5
to
17d2e83
Compare
|
Unable to stage PR (merge conflict) |
|
robodoo 🤖 retry ! |
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2018
When generating new translations (e.g. 'edit translations' button on a view or on a translatable field), the new generated translations have the source as translation value. Set the state to 'to_translate' as it is the default value This change requires to add a fallback in web_editor when computing translated dom When a translation has no value, there is a fallback done in the different translation method (e.g. xml_translate) but, as the node was manually created in edit_translation_mapping, the fallback was missing closes #24391
|
Merged in d65969d |
|
🎉 🎉 🎉 🎉 🎉 |
|
Congrat's !! |
Yeah. robodoo doesn't have a kill order/feature, it closes the PRs best as it can but it doesn't remove the branches. Maybe eventually (we'll see as we use it). |
switch87
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 25, 2018
When generating new translations (e.g. 'edit translations' button on a view or on a translatable field), the new generated translations have the source as translation value. Set the state to 'to_translate' as it is the default value This change requires to add a fallback in web_editor when computing translated dom When a translation has no value, there is a fallback done in the different translation method (e.g. xml_translate) but, as the node was manually created in edit_translation_mapping, the fallback was missing closes odoo#24391
VincentSchippefilt
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 7, 2019
When generating new translations (e.g. 'edit translations' button on a view or on a translatable field), the new generated translations have the source as translation value. Set the state to 'to_translate' as it is the default value This change requires to add a fallback in web_editor when computing translated dom When a translation has no value, there is a fallback done in the different translation method (e.g. xml_translate) but, as the node was manually created in edit_translation_mapping, the fallback was missing closes odoo#24391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating new translations (e.g. 'edit translations' button on a view or
on a translatable field), the new generated translations have the source as
translation value.
Set the state to 'to_translate' as it is the default value