Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master sale invoice kic #25332

Merged
merged 4 commits into from Jul 30, 2018
Merged

Master sale invoice kic #25332

merged 4 commits into from Jul 30, 2018

Conversation

kirti-c
Copy link
Contributor

@kirti-c kirti-c commented Jun 19, 2018

Description of the issue/feature this PR addresses:
Task ID - https://www.odoo.com/web#id=33126&action=327&model=project.task&view_type=form&menu_id=4720

Pad - https://pad.odoo.com/p/r.8cb8ca851e64ed323a23746af9b37883

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD research & development, internal work label Jun 25, 2018
kirti-c and others added 4 commits July 30, 2018 14:57
relabel "Check price" -> "Get rate"
relabel "Set Price" -> "Add to order"

Task ID : 33126
…ents

Purpose
=======

Currently the default invoicing method is not very clear.

Specification
=============

Currently the result is not really correct. We can propose to deduct
the down payment even if there are no down payments on the sales order.

Now the option to deduct down payments will be selected if there
is a downpayment line on the sales order and if there exists at
least one invoice linked to the sales order that is not cancelled.

Task ID : 33126
Purpose
=======

If a SO is only containing lines for which the product is invoiced on
the delivered quantity, the sales order is marked as 'Nothing to Invoice'.

If I add a delivery line, the SO becomes 'To Invoice'. There is not really
a use case in the real life where you will invoice the delivery fees before
invoicing what has been really delivered.

Specification
=============

If an order:
- contains delivery lines or downpayment lines
- If the product on the other lines are invoiced on the delivered quantity
- Nothing has been delivery or can be invoiced for theses lines

Set the invoice status of the sales order to 'Nothing to invoice' instead
of 'To Invoice'

Task ID : 33126
Purpose
=======

When we create a downpayment line of SO and when we delete Invoice of downpayment then so line for downpayment is not deleted.

Specification
=============

Remove the downpayment line in the SO if the related invoice is deleted

Task ID :33126
@tivisse tivisse merged commit eebeb39 into odoo:master Jul 30, 2018
@tivisse tivisse deleted the master-sale-invoice-kic branch July 30, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants