Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]mrp: Apply text decoration properly, apply muted class in done #25565

Closed
wants to merge 1 commit into from

Conversation

tsh-odoo
Copy link
Contributor

@tsh-odoo tsh-odoo commented Jul 2, 2018

Issue-Link: https://www.odoo.com/web#id=1862299&action=333&active_id=1278&model=project.task&view_type=form&menu_id=4720

Pad-Link: https://pad.odoo.com/p/r.078f3d8fb2efa8356d503e9bfd7b8ebc

Before this commit:
Red movelines can be seen instead of text-muted movelines after MO done.

After this commit:
text-muted class has been applied to movelines after MO done.

Issue-ID: 1862299

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@msh-odoo msh-odoo force-pushed the saas-11.4-mrp-css-issue-tsh branch 2 times, most recently from 2787379 to f4abd97 Compare July 3, 2018 13:08
@C3POdoo C3POdoo added the RD research & development, internal work label Jul 3, 2018
@hmo-odoo hmo-odoo changed the title [FIX]Web: CSS Improvement [FIX]mrp: Apply text decoration properly, apply muted class in done Jul 3, 2018
@msh-odoo msh-odoo force-pushed the saas-11.4-mrp-css-issue-tsh branch from f4abd97 to 6540837 Compare July 3, 2018 13:46
@amoyaux amoyaux force-pushed the saas-11.4-mrp-css-issue-tsh branch from 6540837 to efceec8 Compare August 14, 2018 15:15
When the MO is done, the reserved quantity on stock move is equal to 0
and decoration-success, decoration-danger, decoration-muted are all set
on the class. That implies an an uncertain result.

This commit clarify the situation by applying
- decoration-muted if the MO is done
- success, danger or none otherwise

Related to task: #1862299
@amoyaux amoyaux force-pushed the saas-11.4-mrp-css-issue-tsh branch from efceec8 to 113bbcc Compare August 16, 2018 07:50
@amoyaux amoyaux changed the base branch from saas-11.4 to master August 16, 2018 07:59
@amoyaux amoyaux closed this Aug 16, 2018
@amoyaux
Copy link
Contributor

amoyaux commented Aug 16, 2018

push with commit 16d17c5

@amoyaux amoyaux deleted the saas-11.4-mrp-css-issue-tsh branch November 7, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants