[FIX] sale_stock: fix msg argument in assertion #25831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third positional argument is places not msg (which expects a number not a str) https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertAlmostEqual fixes errors like these: if round(abs(second-first), places) == 0: TypeError: 'str' object cannot be interpreted as an integer and gives the intended message when assertion is errornous
MiquelRForgeFlow
approved these changes
Jul 18, 2018
|
@nim-odoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
third positional argument of assertAlmostEqual is places not msg (which expects a number not a str)
https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertAlmostEqual
if assertion fails we get an error like this (and not the intended message):
Current behavior before PR:
Desired behavior after PR is merged:
Introduced in e441f34
Info @wt-io-it
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr