Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master event add activities nje #26092

Closed

Conversation

nje-odoo
Copy link
Contributor

@nje-odoo nje-odoo commented Aug 1, 2018

Task : https://www.odoo.com/web?debug#id=1867620&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Pad : https://pad.odoo.com/p/r.b98f2eb071d997022f50d028d02d5dc8
Description of the issue/feature this PR addresses: add schedule activity in

event.event
event.registration
Payments (account.payment)
Asserts (account.asset.asset)
Budgets (crossovered.budget)
Work order Operations (mrp.workorder)
Purchase Agreements (purchase.requisition)
Landend Costs (stock.landed.cost)
Batch Picking (stock.picking.batch)
quality.alerts

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD research & development, internal work label Aug 1, 2018
@nje-odoo nje-odoo force-pushed the master-event-add-activities-nje branch from 019b769 to 3a2b186 Compare October 23, 2018 09:20
@robodoo robodoo added seen 🙂 CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 23, 2018
@mba-odoo mba-odoo force-pushed the master-event-add-activities-nje branch from 743c5e4 to 713a48f Compare October 24, 2018 13:24
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 24, 2018
@mba-odoo
Copy link
Contributor

LGTM

Copy link
Contributor

@Xavier-Do Xavier-Do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details to fix, except that it looks good!

@@ -383,7 +383,7 @@ def create_payments(self):

class account_payment(models.Model):
_name = "account.payment"
_inherit = ['mail.thread', 'account.abstract.payment']
_inherit = ['mail.thread', 'account.abstract.payment', 'mail.activity.mixin']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have 'mail.activity.mixin just after mail.thread except if you have a good reason to keep this in this order.
['mail.thread, 'mail.activity.mixin', 'account.abstract.payment']

@nje-odoo nje-odoo force-pushed the master-event-add-activities-nje branch from 713a48f to 729cc46 Compare November 26, 2018 10:45
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Nov 26, 2018
@mba-odoo
Copy link
Contributor

@Xavier-Do , done changes 👍

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Nov 26, 2018
@Xavier-Do Xavier-Do force-pushed the master-event-add-activities-nje branch from 729cc46 to 9c0b600 Compare November 26, 2018 12:20
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Nov 26, 2018
*: account, event, mrp, purchase_requisition, stock_landed_cost, stock_picking_batch

Add activity on below models:
account.payment
event.event
event.registration
mrp.workorder
purchase.requisition
stock.landed.cost
stock.picking.batch

Related Task ID : 1867620
@Xavier-Do Xavier-Do force-pushed the master-event-add-activities-nje branch from 9c0b600 to 28cd0e6 Compare November 26, 2018 12:28
@Xavier-Do
Copy link
Contributor

@robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Nov 26, 2018
@robodoo
Copy link
Contributor

robodoo commented Nov 26, 2018

Linked pull request(s) odoo/enterprise#2942 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Nov 26, 2018
*: account, event, mrp, purchase_requisition, stock_landed_cost, stock_picking_batch

Add activity on below models:
account.payment
event.event
event.registration
mrp.workorder
purchase.requisition
stock.landed.cost
stock.picking.batch

Related Task ID : 1867620

closes #26092
@robodoo
Copy link
Contributor

robodoo commented Nov 26, 2018

Merged, thanks!

@robodoo robodoo closed this Nov 26, 2018
yajo pushed a commit to Tecnativa/odoo that referenced this pull request Sep 17, 2019
…urchase_requisition, stock_landed_cost, stock_picking_batch

Add activity on below models:
account.payment
event.event
event.registration
mrp.workorder
purchase.requisition
stock.landed.cost
stock.picking.batch

Related Task ID : 1867620

closes odoo#26092

Backport of b0a6f33
@nim-odoo nim-odoo deleted the master-event-add-activities-nje branch September 25, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants