[IMP] point_of_sale: extension point xml rendering

[blaggacao]

Before, extending the xml rendering environment was a matter of overriding the
whole method.

This commit enables a clean extenstion point to alter the rendering dict in
the mean time till a thourough refactoring in the near future according to the
new js guidlines.

Description of the issue/feature this PR addresses:

• Missing (clean) extension point made alterations to the xml rendering context a real pain

Current behavior before PR:

• Unclean extension forces to rewrite the whole method.
• Maintainability of downstream code is suboptimal.

Desired behavior after PR is merged:

• Clean extension is possible
• (As if the this js code was already refactored according to the new style)

Note: Please do not close, even if not immediately accepted (wishlist tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@xoe-labs

[blaggacao]

Note: Unfortunately, the diff is uglier than it needs to be...

[blaggacao]

@switch87 Could you have a kind look at this? The problem it solves is to be able to manipulate the receipt environment before passing it to the header and footer rendering, so that header and footer can make use of an custom extended environment.

This enables client-by-client customization in an extended (legal) receipt environment.

EDIT: This equivalent gist looks nicer than the PR diff, see this line for what it does in reality.

[switch87]

Will do! 👍

[blaggacao]

FYI, what I actually do:

    _export_for_printing: function(){
      var _super = order_model_super._export_for_printing.apply(this, arguments);
      var company = this.pos.company;
      var client  = this.get('client');
      _super.company = _.extend(_super.company, {
        legalname: company.l10n_co_oficial_name,
        fiscal_regime: company.l10n_co_regimen_char,
        vat: company.vat_formatted,
        economic_activity: company.l10n_co_economic_activity_id,
      });
      if (!!client) {
          _super.client = {
            name: client.name,
            legalname: client.l10n_co_oficial_name,
            vat: client.vat_formatted,
            vat_label: company.country && company.country.vat_label || '',
          };
      }
      return _super;
    }

[switch87]

It will have to wait until next year.

[blaggacao]

Happy new year! I've no hurry, I'm maintaining a patched Odoo for the many reasons I sporadically try to push one or the other PR. If it will be included in master, I'm more than happy on the long run...

[blaggacao]

@switch87 Could you give this a go once again? It would be nice, could this be merged...

[blaggacao]

@switch87 Shall we? 😉

[switch87]

@pimodoo I think this would be an improvement. What do you think?

[pedrobaeza]

Is this still relevant?