[IMP] Keep SQL constraint #27045
Closed
[IMP] Keep SQL constraint #27045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKE-be
approved these changes
Sep 18, 2018
nseinlet
force-pushed
the
saas-11.5-webisteconstraint-nse
branch
from
ee325ac
to
385ff09
Compare
nseinlet
force-pushed
the
saas-11.5-webisteconstraint-nse
branch
2 times, most recently
from
8828dc0
to
1b98184
Compare
Constraints in SQL are faster than python equivalent. Adding a coalesce in PostgreSQL constraint doesn't seems possible. This combination of constraint and weird named unique index is the fastest way to ensure a unique constraint with NULL values. This index require the website_id to be present in the res_users table. To do this, a stored readonly related field is used.
nseinlet
force-pushed
the
saas-11.5-webisteconstraint-nse
branch
from
1b98184
to
2d027bb
Compare
odony
approved these changes
Sep 20, 2018
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraints in SQL are faster than python equivalent.
Adding a coalesce in PostgreSQL constraint doesn't seems possible.
This combination of constraint and weird named unique index is the
fastest way to ensure a unique constraint with NULL values.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr