New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] sale_mrp, sale_stock: procurement qty of kits #27064
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim-odoo
force-pushed
the
11.0-opw-1881227-change_qty_kit-nim
branch
3 times, most recently
from
September 19, 2018 09:03
771a90e
to
6926439
Compare
- Create a BOM kit for product F with: 2 Unit(s) of A 1 Unit(s) of B - Create a SO for 1 Unit(s) of F, confirm => a picking with 2 Unit(s) of A and 1 Unit(s) of B is created - Modify the Ordered Qty to 2 Unit(s) The picking is not updated. This is because `_get_qty_procurement` wrongly computed the product quantity based on the moves' quantities. This is not correct since the moves are for products A and B, not product F. At this point, it is not possible to make sure of the real procurement quantity. therefore, we use a very simple approach: we compare the sold quantity before and after modification, and return the difference. opw-1881227
nim-odoo
force-pushed
the
11.0-opw-1881227-change_qty_kit-nim
branch
from
September 19, 2018 09:27
6926439
to
7578d13
Compare
ping @sle-odoo |
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 27, 2018
- Create a BOM kit for product F with: 2 Unit(s) of A 1 Unit(s) of B - Create a SO for 1 Unit(s) of F, confirm => a picking with 2 Unit(s) of A and 1 Unit(s) of B is created - Modify the Ordered Qty to 2 Unit(s) The picking is not updated. This is because `_get_qty_procurement` wrongly computed the product quantity based on the moves' quantities. This is not correct since the moves are for products A and B, not product F. At this point, it is not possible to make sure of the real procurement quantity. therefore, we use a very simple approach: we compare the sold quantity before and after modification, and return the difference. opw-1881227 closes #27064
Merged in d3ee7a7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Unit(s) of A
1 Unit(s) of B
=> a picking with 2 Unit(s) of A and 1 Unit(s) of B is created
The picking is not updated.
This is because
_get_qty_procurement
wrongly computed the productquantity based on the moves' quantities. This is not correct since the
moves are for products A and B, not product F.
At this point, it is not possible to make sure of the real procurement
quantity. therefore, we use a very simple approach: we compare the sold
quantity before and after modification, and return the difference.
opw-1881227