[FIX] document: updateEnv->redraw on not form view #27146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nle-odoo
force-pushed
the
11.0-document-opw-1865736-nle
branch
from
a20ec4a
to
a54c385
Compare
nle-odoo
force-pushed
the
11.0-document-opw-1865736-nle
branch
from
a54c385
to
e457466
Compare
In ac1e187 some unecessary code and RPC were removed by ignoring attachments in the sidebar when they would never be shown. But there was an regression since `updateEnv` function would not longer call redraw (which is also called in _super function). report: odoo@ac1e187eea3#r30569171 related to opw-1865736 closes odoo#27146
nle-odoo
force-pushed
the
11.0-document-opw-1865736-nle
branch
from
e457466
to
10cb745
Compare
nle-odoo
referenced
this pull request
Sep 21, 2018
Since cce70fd the attachment menu is only displayed for form view. But if in another view there is active_ids (eg. selecting record in a list view), we will still make a query to ir.attachment without using the result. Without the code change, the added test would fail when doing a search_read RPC call to ir.attachment model. related to #26213
kebeclibre
approved these changes
Sep 21, 2018
robodoo
pushed a commit
that referenced
this pull request
Sep 21, 2018
In ac1e187 some unecessary code and RPC were removed by ignoring attachments in the sidebar when they would never be shown. But there was an regression since `updateEnv` function would not longer call redraw (which is also called in _super function). report: ac1e187eea3#r30569171 related to opw-1865736 closes #27146
|
Merged in b3a3ad8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ac1e187 some unecessary code and RPC were removed by ignoring
attachments in the sidebar when they would never be shown.
But there was an regression since
updateEnvfunction would notlonger call redraw (which is also called in _super function).
related to opw-1865736